Skip to content

chore(tekton,scripts): drop the release-6.5 FIPS CI trigger and its scripts - #5534

Merged
ti-chi-bot[bot] merged 1 commit into
mainfrom
chore/drop-fips-ci
Nov 11, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
mainfrom
chore/drop-fips-ci

Conversation

@wuhuizuo

Copy link
Copy Markdown
Contributor

Why

Per the decision on the FIPS item of this finding: if the FIPS CI only applies to
the release-6.5 branch series, delete it instead of re-enabling TLS on a path
nobody runs.

What the repository actually had

  • tekton/v1/triggers/triggers/env-gcp/_/git-push-on-fips-branches.yaml — the
    only CI entry point, and it fires profile: fips builds for a single
    hard-coded branch, feature/release-6.5-fips (6 repos).
  • No Jenkins job folder, Prow job or pipeline references the FIPS scripts, and
    nothing calls them: they are orphans of the deleted pull_*_fips jobs.

Changes

  • Delete the trigger and its kustomization entry.
  • Delete the orphaned scripts:
    • scripts/pingcap/tidb/release-6.5-fips/ (2 scripts)
    • scripts/pingcap/tiflow/release-6.5-fips/ (5 scripts)

That removes the only curl --insecure / wget --no-check-certificate in the
repository (pingcap_download_artifacts.sh,
br_integration_test_download_dependency.sh) by deleting the code rather than
by re-enabling TLS on top of the internal OCI file service.

The fips build profile stays: pingcap/tidb-operator/git-create-tag-fips.yaml
and the shared build pipeline still accept it.

Verification

pull-verify-tekton-yaml validates the remaining Tekton manifests and the
kustomization; pull-verify-jenkins-job-references and the policy gates run on
the script removals.

If the FIPS build needs to come back, it should come back with a repository that
serves its artifacts over a certificate the build node trusts, not with
--insecure.

…cripts

The only CI entry point for the FIPS builds was
`tekton/v1/triggers/triggers/env-gcp/_/git-push-on-fips-branches.yaml`, which
fires `profile: fips` builds for a single hard-coded branch,
`feature/release-6.5-fips`. The pull-request side is already gone: no Jenkins job
folder, Prow job or pipeline references the FIPS scripts, and nothing calls them.

Remove the trigger (and its kustomization entry) together with the orphaned
scripts it existed for:

- `scripts/pingcap/tidb/release-6.5-fips/` (2 scripts)
- `scripts/pingcap/tiflow/release-6.5-fips/` (5 scripts)

Those scripts are the only place that downloaded release artifacts with
`curl --insecure` / `wget --no-check-certificate`
(`pingcap_download_artifacts.sh`, `br_integration_test_download_dependency.sh`),
so deleting them removes the bypass rather than re-enabling TLS on a path nothing
uses.

The `fips` build profile itself stays: the tag-creation trigger for
`tidb-operator` and the shared build pipeline still accept it.

@ti-chi-bot ti-chi-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary

This pull request removes all configurations and scripts related to the release-6.5-fips CI trigger and its associated tasks. The approach involves deleting orphaned Tekton triggers, related kustomization entries, and unused scripts across multiple repositories. The changes are thorough, and the PR description provides sufficient context for the rationale and verification steps. Overall, this appears to be a well-executed cleanup operation, but there are a few areas for potential improvement in documentation and process safeguards.


Critical Issues

None identified. The PR cleanly removes unused resources without introducing new functionality or dependencies.


Code Improvements

  • File: tekton/v1/triggers/triggers/env-gcp/kustomization.yaml (Line 22)
    The removal of _git-push-on-fips-branches.yaml reduces complexity, but consider checking if there are any indirect dependencies or references to this file elsewhere in the repository to avoid potential orphaned configurations.
    Suggested Action: Perform a repository-wide search to ensure no lingering references.

Best Practices

  • Documentation

    • Issue: The PR description is detailed but does not explicitly state whether any documentation or external references to the removed scripts (e.g., README, CI guides, or team wikis) need updating.
    • Suggested Action: Verify and update any documentation or references that might mention the removed release-6.5-fips CI workflows or associated scripts.
  • Testing Coverage

    • Issue: While the PR mentions that standard Tekton and Jenkins validations were run, it does not specify if any additional regression testing was performed to ensure that removing these scripts has no unintended side effects.
    • Suggested Action: Add a note confirming that regression tests (if applicable) were executed and passed successfully.
  • Commit History

    • Issue: This cleanup spans multiple critical areas (Tekton triggers, CI scripts, and kustomizations). If these deletions are spread across unrelated subsystems, consider splitting commits logically to improve traceability.
    • Suggested Action: Ensure commits are atomic, e.g., one commit for Tekton changes and another for script deletions.

Additional Observations

  • The removal of scripts containing insecure curl --insecure and wget --no-check-certificate commands is a positive step toward improving security hygiene.
  • The extensive use of hard-coded paths and branch names in the deleted scripts highlights potential technical debt in the former implementation. Future CI workflows should consider parameterization to improve flexibility and maintainability.

@ti-chi-bot ti-chi-bot Bot added the size/XXL label Nov 11, 2026

@wuhuizuo wuhuizuo left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot

ti-chi-bot Bot commented Nov 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Nov 11, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 6a1c896 into main Nov 11, 2026
8 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the chore/drop-fips-ci branch November 11, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant