Repository navigation
chore(tekton,scripts): drop the release-6.5 FIPS CI trigger and its scripts - #5534
Conversation
…cripts The only CI entry point for the FIPS builds was `tekton/v1/triggers/triggers/env-gcp/_/git-push-on-fips-branches.yaml`, which fires `profile: fips` builds for a single hard-coded branch, `feature/release-6.5-fips`. The pull-request side is already gone: no Jenkins job folder, Prow job or pipeline references the FIPS scripts, and nothing calls them. Remove the trigger (and its kustomization entry) together with the orphaned scripts it existed for: - `scripts/pingcap/tidb/release-6.5-fips/` (2 scripts) - `scripts/pingcap/tiflow/release-6.5-fips/` (5 scripts) Those scripts are the only place that downloaded release artifacts with `curl --insecure` / `wget --no-check-certificate` (`pingcap_download_artifacts.sh`, `br_integration_test_download_dependency.sh`), so deleting them removes the bypass rather than re-enabling TLS on a path nothing uses. The `fips` build profile itself stays: the tag-creation trigger for `tidb-operator` and the shared build pipeline still accept it.
There was a problem hiding this comment.
I have already done a preliminary review for you, and I hope to help you do a better job.
Summary
This pull request removes all configurations and scripts related to the release-6.5-fips CI trigger and its associated tasks. The approach involves deleting orphaned Tekton triggers, related kustomization entries, and unused scripts across multiple repositories. The changes are thorough, and the PR description provides sufficient context for the rationale and verification steps. Overall, this appears to be a well-executed cleanup operation, but there are a few areas for potential improvement in documentation and process safeguards.
Critical Issues
None identified. The PR cleanly removes unused resources without introducing new functionality or dependencies.
Code Improvements
- File:
tekton/v1/triggers/triggers/env-gcp/kustomization.yaml(Line 22)
The removal of_git-push-on-fips-branches.yamlreduces complexity, but consider checking if there are any indirect dependencies or references to this file elsewhere in the repository to avoid potential orphaned configurations.
Suggested Action: Perform a repository-wide search to ensure no lingering references.
Best Practices
-
Documentation
- Issue: The PR description is detailed but does not explicitly state whether any documentation or external references to the removed scripts (e.g., README, CI guides, or team wikis) need updating.
- Suggested Action: Verify and update any documentation or references that might mention the removed
release-6.5-fipsCI workflows or associated scripts.
-
Testing Coverage
- Issue: While the PR mentions that standard Tekton and Jenkins validations were run, it does not specify if any additional regression testing was performed to ensure that removing these scripts has no unintended side effects.
- Suggested Action: Add a note confirming that regression tests (if applicable) were executed and passed successfully.
-
Commit History
- Issue: This cleanup spans multiple critical areas (Tekton triggers, CI scripts, and kustomizations). If these deletions are spread across unrelated subsystems, consider splitting commits logically to improve traceability.
- Suggested Action: Ensure commits are atomic, e.g., one commit for Tekton changes and another for script deletions.
Additional Observations
- The removal of scripts containing insecure
curl --insecureandwget --no-check-certificatecommands is a positive step toward improving security hygiene. - The extensive use of hard-coded paths and branch names in the deleted scripts highlights potential technical debt in the former implementation. Future CI workflows should consider parameterization to improve flexibility and maintainability.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Why
Per the decision on the FIPS item of this finding: if the FIPS CI only applies to
the release-6.5 branch series, delete it instead of re-enabling TLS on a path
nobody runs.
What the repository actually had
tekton/v1/triggers/triggers/env-gcp/_/git-push-on-fips-branches.yaml— theonly CI entry point, and it fires
profile: fipsbuilds for a singlehard-coded branch,
feature/release-6.5-fips(6 repos).nothing calls them: they are orphans of the deleted
pull_*_fipsjobs.Changes
scripts/pingcap/tidb/release-6.5-fips/(2 scripts)scripts/pingcap/tiflow/release-6.5-fips/(5 scripts)That removes the only
curl --insecure/wget --no-check-certificatein therepository (
pingcap_download_artifacts.sh,br_integration_test_download_dependency.sh) by deleting the code rather thanby re-enabling TLS on top of the internal OCI file service.
The
fipsbuild profile stays:pingcap/tidb-operator/git-create-tag-fips.yamland the shared build pipeline still accept it.
Verification
pull-verify-tekton-yamlvalidates the remaining Tekton manifests and thekustomization;
pull-verify-jenkins-job-referencesand the policy gates run onthe script removals.
If the FIPS build needs to come back, it should come back with a repository that
serves its artifacts over a certificate the build node trusts, not with
--insecure.