Skip to content

test(ci): canary for the Tekton validation presubmit - #5551

Closed
wuhuizuo wants to merge 1 commit into
mainfrom
test/tekton-validator-canary
Closed

wuhuizuo wants to merge 1 commit into
mainfrom
test/tekton-validator-canary

Conversation

@wuhuizuo

Copy link
Copy Markdown
Contributor

Temporary canary: a comment-only change to one Tekton task, to confirm pull-verify-tekton-yaml now runs (it could not start under bash on alpine). Will be closed without merging.

@ti-chi-bot

ti-chi-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dillon-zheng for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary
This PR introduces a single comment line in a Tekton Task YAML to serve as a canary for the Tekton validation presubmit pipeline. The goal is to verify that the pull-verify-tekton-yaml check runs successfully, addressing a prior issue where it failed to start under bash on Alpine. The change is minimal and non-functional, making it low risk and straightforward.


Code Improvements

  • Potential confusion from a lingering canary comment
    • File: tekton/v1/tasks/pingcap-get-set-release-version.yaml (line 2)
    • Issue: Even though the PR states this is temporary and will be closed without merging, leaving this comment in the main branch could confuse future maintainers or automated tools that parse comments.
    • Suggestion: Ensure the comment is removed before merging or explicitly document in the PR or repo guidelines about such temporary canaries. Alternatively, consider using a dedicated testing branch or a separate minimal test YAML to avoid polluting production files.

Best Practices

  • Documentation of the canary purpose

    • File: tekton/v1/tasks/pingcap-get-set-release-version.yaml (line 2)
    • Issue: The comment # canary: exercise the Tekton validation presubmit is terse and could be unclear to readers unfamiliar with the context.
    • Suggestion: Expand the comment to clarify the purpose, duration, and next steps, for example:
      # canary: temporary comment to trigger Tekton validation presubmit for debugging purposes
      # to be removed after validation is confirmed successful
  • Testing coverage

    • Since this PR is a comment-only change to trigger CI, no additional tests are necessary. However, confirm that the pipeline pull-verify-tekton-yaml actually runs and reports results as expected.

No critical issues identified given the nature of this PR. The change is minimal and fit for its intended purpose.

@ti-chi-bot ti-chi-bot Bot added the size/XS label Nov 12, 2026
@wuhuizuo

Copy link
Copy Markdown
Contributor Author

/test pull-verify-tekton-yaml

@ti-chi-bot

ti-chi-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

@wuhuizuo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify-tekton-yaml 5bf3469 link true /test pull-verify-tekton-yaml

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wuhuizuo

Copy link
Copy Markdown
Contributor Author

Canary achieved its purpose: it proved the job was still masked (server dry-run has no kubeconfig). Superseded by the offline validator; will re-run a canary after that lands.

@wuhuizuo wuhuizuo closed this Nov 12, 2026
@wuhuizuo
wuhuizuo deleted the test/tekton-validator-canary branch November 12, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant