Skip to content

test(ci): canary for the offline Tekton validator - #5554

Closed
wuhuizuo wants to merge 1 commit into
mainfrom
test/tekton-validator-canary2
Closed

wuhuizuo wants to merge 1 commit into
mainfrom
test/tekton-validator-canary2

Conversation

@wuhuizuo

Copy link
Copy Markdown
Contributor

Temporary canary: comment-only change to one Tekton task, to confirm pull-verify-tekton-yaml runs and passes with the offline (no kubeconfig) validation. Will be closed without merging.

@ti-chi-bot

ti-chi-bot Bot commented Nov 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dillon-zheng for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary:
This PR introduces a single comment line to a Tekton task YAML file as a canary to verify that the pull-verify-tekton-yaml pipeline runs and passes with the offline Tekton validator. The change is minimal and purely for testing CI behavior, with no functional modifications. The overall quality is appropriate given the intent as a temporary, comment-only test.


Code Improvements

  • File: tekton/v1/tasks/pingcap-get-set-release-version.yaml (line 2)
    • The added comment # canary: exercise the offline Tekton validator is clear for its intent but could be slightly enhanced to explicitly mention this is a temporary change to avoid confusion if seen later, e.g.:
      # canary: temporary comment to exercise offline Tekton validator, will be removed
    • This will help reviewers or maintainers quickly understand the transient nature without referring back to PR descriptions.

Best Practices

  • File: tekton/v1/tasks/pingcap-get-set-release-version.yaml (line 2)
    • While the PR description clarifies that this is temporary and will not be merged, it is a good practice to add a corresponding comment in the PR or commit message indicating it is a non-mergeable test change. This avoids accidental merges in busy repos.
    • Consider tagging the commit or branch with a [WIP] or [DO NOT MERGE] prefix for clarity.

No critical issues or broken functionality found given this PR only adds a comment for CI testing purposes.

@ti-chi-bot ti-chi-bot Bot added the size/XS label Nov 12, 2026
@wuhuizuo

Copy link
Copy Markdown
Contributor Author

Canary green: pull-verify-tekton-yaml runs and passes with the offline validator. Closing without merging.

@wuhuizuo wuhuizuo closed this Nov 12, 2026
@wuhuizuo
wuhuizuo deleted the test/tekton-validator-canary2 branch November 12, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant