Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:
This PR introduces a single comment line to a Tekton task YAML file as a canary to verify that the pull-verify-tekton-yaml pipeline runs and passes with the offline Tekton validator. The change is minimal and purely for testing CI behavior, with no functional modifications. The overall quality is appropriate given the intent as a temporary, comment-only test.
Code Improvements
- File:
tekton/v1/tasks/pingcap-get-set-release-version.yaml(line 2)- The added comment
# canary: exercise the offline Tekton validatoris clear for its intent but could be slightly enhanced to explicitly mention this is a temporary change to avoid confusion if seen later, e.g.:# canary: temporary comment to exercise offline Tekton validator, will be removed - This will help reviewers or maintainers quickly understand the transient nature without referring back to PR descriptions.
- The added comment
Best Practices
- File:
tekton/v1/tasks/pingcap-get-set-release-version.yaml(line 2)- While the PR description clarifies that this is temporary and will not be merged, it is a good practice to add a corresponding comment in the PR or commit message indicating it is a non-mergeable test change. This avoids accidental merges in busy repos.
- Consider tagging the commit or branch with a
[WIP]or[DO NOT MERGE]prefix for clarity.
No critical issues or broken functionality found given this PR only adds a comment for CI testing purposes.
|
Canary green: pull-verify-tekton-yaml runs and passes with the offline validator. Closing without merging. |
Temporary canary: comment-only change to one Tekton task, to confirm
pull-verify-tekton-yamlruns and passes with the offline (no kubeconfig) validation. Will be closed without merging.