Use native gettext for Pinta's translations - #2263
Merged
Merged
Conversation
- Related to PR #2261, using the native gettext library is the simplest way to also support translations for .ui files - no additional work is needed since GTK already calls dgettext() for any translatable strings when loading the xml file - We already bundle libintl with Pinta (since it's required by GTK, libadwaita etc) so this doesn't require any additional packaging. I think the original motivation for using the managed Ngettext library was because we no longer had any bindings to gettext when porting to GTK3 - for GTK2 we used the Mono.Unix.Catalog wrapper for the native library - Several of the native methods are already wrapped via GLib and have bindings available (e.g. GLib.Functions.Dgettext()) so this just requires a couple custom bindings for functions like textdomain(). We previously already had one binding for bindtextdomain() to configure libadwaita's translation directory for the macOS app bundle
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to PR Add an initial version of a preferences dialog #2261, using the native gettext library is the simplest way to also support translations for .ui files - no additional work is needed since GTK already calls dgettext() for any translatable strings when loading the xml file
We already bundle libintl with Pinta (since it's required by GTK, libadwaita etc) so this doesn't require any additional packaging. I think the original motivation for using the managed Ngettext library was because we no longer had any bindings to gettext when porting to GTK3 - for GTK2 we used the Mono.Unix.Catalog wrapper for the native library
Several of the native methods are already wrapped via GLib and have bindings available (e.g. GLib.Functions.Dgettext()) so this just requires a couple custom bindings for functions like textdomain(). We previously already had one binding for bindtextdomain() to configure libadwaita's translation directory for the macOS app bundle
Description of Changes
Checklist