Skip to content

fix(service): prevent orphaned "processing action" notification #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Praveensenpai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(service): prevent orphaned "processing action" notification #2939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...src/main/java/com/theveloper/pixelplay/data/service/LocalOnlyMediaNotificationProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ class LocalOnlyMediaNotificationProvider(
}.getOrElse {
notification.notification
}
return MediaNotification(notification.notificationId, localOnlyNotification)
// Same ID as MusicService's temporary foreground notification, so media updates
// replace it instead of leaving it behind as an orphaned notification.
return MediaNotification(MusicService.NOTIFICATION_ID, localOnlyNotification)
}

override fun handleCustomCommand(
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/java/com/theveloper/pixelplay/data/service/MusicService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,8 @@ class MusicService : MediaLibraryService() {

companion object {
private const val TAG = "MusicService_PixelPlay"

/** Also used by [LocalOnlyMediaNotificationProvider]; the IDs must stay in sync. */
const val NOTIFICATION_ID = 101
const val ACTION_SLEEP_TIMER_EXPIRED = "com.theveloper.pixelplay.ACTION_SLEEP_TIMER_EXPIRED"
const val EXTRA_FORCE_FOREGROUND_ON_START =
Expand Down