[stakach]

Closes #645

Desks are moving from desks zone metadata to _DESKS_ assets (init migrate:desk_assets). This PR moves every driver that reads desk metadata onto a shared mixin. One setting, use_desk_assets, switches the source of truth, so production systems can move over one at a time.

Changes

• staff_api
  • assets takes limit/next_page. Like get_members, the first result carries a next_page link, which callers pass back to fetch the next page.
  • New update_asset (PATCH /api/engine/v2/assets/:id).
• Place::DeskSource (drivers/place/desk_source.cr)
  • level_desks and building_desks return one Desk shape from either source.
  • Custom keys (floorsense_id, gobright_desk_name, …) come from other_data in both modes, through desk[key]? / desk.value(key).
  • The legacy metadata readers are @[Deprecated("desk metadata: set use_desk_assets and remove")].
• Drivers moved to the mixin, each with use_desk_assets: false by default and one commit per driver:
  • floorsense: custom_bookings_sync, mobile_checkin_logic
  • desk_bookings_locations
  • booking approval: booking_approver, booking_approval_workflows
  • area_management
  • desk: control, allocations
  • grant_area_access
  • orbility approvals
  • gobright location_service
  • asset_name_resolver, with auto_release, at_capacity_mailer and booking_notifier
  • llm: workplace, campus

Rollout

1. Run task migrate:desk_assets from init. Unmapped desk keys are kept in Asset#other_data.
2. Set use_desk_assets: true on the org zone. The setting is inherited by every driver.

Cleanup

Running grep -rn 'Deprecated("desk metadata' drivers finds every legacy path: desk_source.cr (×2), desk/allocations.cr (metadata write) and bookings/asset_name_resolver.cr. Compiling any driver that still uses them prints a deprecation warning.

Review

• Harness: 17 tested, 0 failures, 0 timeouts, 0 without spec across every touched driver. Each spec covers both modes, and assets mode includes a two-page response. Empty spec stubs were built out for custom_bookings_sync, desk/allocations, grant_area_access, orbility/approvals and area_management (whose spec used to test AreaCount).
• Behaviour to check:
  • desk/allocations: the CSV export and allocation import use a stable external id (map_id in assets mode, which the migration fills from the original desk id). The external desk management tool doesn't see Asset#ids. Writes go to the assets.
  • grant_area_access: assets can have several security groups, so desks, the sync_blocked status and security_zone_report now hold arrays of groups instead of a single string.
  • area_management: desk ids sent to locations are the desk map_id, which is the floor-plan id rather than asset-xxx.
  • The mixin is more tolerant of incomplete metadata:
    • a desk with no id falls back to map_id
    • a missing groups is treated as empty
    • bookable: "FALSE" means not bookable
    • a missing gobright_desk_name skips that desk rather than raising
  • llm/workplace and llm/campus: they return a slim DeskDetails, so other_data never reaches the LLM.

🤖 Generated with Claude Code