Repository navigation
fix(workplace): room and desk start times stop before closing time - #654
Merged
Merged
Conversation
With bookable hours set, the new room and desk flows offered the closing time as a start time, which leaves no valid duration. The start-time fields now pass the shortest duration option to the time field, so the last start leaves room for a booking that ends by closing time. The room and desk E2E time tests now assert this. Refs: PPT-2872
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
camreeves
added a commit
that referenced
this pull request
Nov 3, 2026
Brings in #654 (PPT-2872), #655 (PPT-2871) and the desk asset changes from #656, which the settings specs are updated for next. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VtrxAzu8XnqXeQG3QbRXt
camreeves
added a commit
that referenced
this pull request
Nov 3, 2026
…asset fixes - desks and events bookable_hours: the last start now leaves room for the shortest duration (PPT-2872, #654). The closing-time case asserts no start is offered at closing time, and the specs pin min_duration so the expected last start doesn't depend on the stack's settings. - parking use_building_timezone: drop test.fail now that an explicit parking false overrides bookings (PPT-2871, #655). - desks.use_assets: the assets fixture also answers the building-wide `zones=<building>` query the desk list sends since #656. - QA status doc updated to match. Full settings and settings-browser run with develop merged in: 443 passed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VtrxAzu8XnqXeQG3QbRXt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
bookable_hoursset to 09:00–17:00, the new Workplace room and desk flows offered 17:00 as a start time. A booking that starts at closing time has no valid duration.The shared time field already has a
min_durationinput that moves the last start back by the shortest booking. The older forms bind it. The new room and desk start-time fields did not, so the window end counted as a valid start.Jira: PPT-2872
Solution
meeting-flow-details,meeting-flow-space-select,desk-flow-detailsanddesk-flow-selectnow bindmin_durationto the shortest duration option (min(min_duration, ...custom_duration_options)). This is the same rule aslibs/eventsmeeting-form-details.desk-filtersbindsmin_durationto 60, the minimum of its duration field.bookable_hoursrows indocs/settings/workplace.mdgive the rule for the last start time.With 09:00–17:00 and a 30 minute minimum, the last start is now 16:30.
Verification
room-times.spec.tsanddesk-times.spec.ts(local E2E) now check that the last start is at mostend - min_duration. Without the source change, both fail with 17:00 offered. With it, 7/7 pass against the local stack.workplaceandbookingstests pass.workplacebuilds.bun run e2e:typecheckpasses.Follow-up: the open PR #595 has
desk-booking.bookable-hours.spec.ts, which expects 17:00 as the last desk start. Update that test after this merges.Reviewed with sol-loop: 1 round with gpt-6.1-sol. Sol verdict: approved
Changes made by Claude Opus 5.5 (
claude-opus-5-5) in Claude Code, running in T3 Code.🤖 Generated with Claude Code