fix(visualizer): create shadow-map FBO in headless mode\n\nPreviously… - #100
Open
heesup wants to merge 1 commit into
Open
fix(visualizer): create shadow-map FBO in headless mode\n\nPreviously…#100heesup wants to merge 1 commit into
heesup wants to merge 1 commit into
Conversation
Contributor
Author
|
But I'm not an expert on OpenGL, and I think it might cause any memory leaks or driver crashes. So please ignore this PR if it's not tested well or makes the visualizer unstable. Thank you! |
… shadow-map framebuffer and depth texture were only created\nin windowed mode, causing shadows to be missing in offscreen renders.\nNow the same FBO setup is performed for headless mode as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my example code using Visualizer headless rendering, the shadow-map framebuffer and depth texture were only created in windowed mode, causing shadows to be missing in offscreen renders.
This fix will use the same FBO setup as is performed for headless mode as well.
Before
After
Thank you!