Skip to content

feat: Migrate nix setup to uv, and add a github action for testing env#1591

Merged
Naramsim merged 1 commit into
PokeAPI:masterfrom
FallenDeity:update-nix-config
Jul 24, 2026
Merged

feat: Migrate nix setup to uv, and add a github action for testing env#1591
Naramsim merged 1 commit into
PokeAPI:masterfrom
FallenDeity:update-nix-config

Conversation

@FallenDeity

@FallenDeity FallenDeity commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Change description

Updated the nix env to use uv to install deps, also added a github action to test working inside nix env

image

resolves #1583

AI coding assistance disclosure

None

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@FallenDeity
FallenDeity marked this pull request as ready for review July 5, 2026 11:13
@Naramsim

Naramsim commented Jul 5, 2026

Copy link
Copy Markdown
Member

Seems ok, I'll ping @Indyandie if he has some time to review properly.

@Indyandie

Copy link
Copy Markdown
Contributor

@FallenDeity @Naramsim I'm not too familiar with uv yet. The default.nix seems correct and should work. To be certain I would need to test myself but I don't want hold things up.

🤔 Hmm... would it be a bad idea to switch over to a flake though? Here's an example https://github.com/akirak/flake-templates/blob/master/python-uv-simple/flake.nix

@Naramsim

Copy link
Copy Markdown
Member

I checked a bit the docs and everything seems good! Thanks for the PR @FallenDeity !

@Naramsim
Naramsim merged commit 445eaef into PokeAPI:master Jul 24, 2026
20 checks passed
@pokeapi-machine-user

Copy link
Copy Markdown

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user

Copy link
Copy Markdown

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nix checkup

4 participants