Skip to content

PokemonSV: test the Blueberry quest detector on reference frames - #1641

Closed
dayfine wants to merge 2 commits into
PokemonAutomation:mainfrom
dayfine:bbq/quest-detector-tests
Closed

dayfine wants to merge 2 commits into
PokemonAutomation:mainfrom
dayfine:bbq/quest-detector-tests

Conversation

@dayfine

@dayfine dayfine commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Depends on: #1628, which adds the frames. Merge that first. Until then this PR also shows #1628's commit; the change here is the last commit only.

The two quest panel frames that #1628 adds for the BP reader also show the three blue quests. This PR uses them to test BlueberryQuestDetector, the OCR that the BBQ Farmer depends on to read its quests, which had no tests until now.

Tests

There are 16 PokemonSV::BlueberryQuestDetector cases: 2 frames × 4 slots × 1080p and 720p, all with Traditional Chinese OCR.

Frame Slot 1 Slot 2 Slot 3 Slot 4
6750.png catch-any sneak-up auto-10 (empty)
6740.png photo-swim sneak-up auto-10 (empty)

All 16 pass, along with #1628's 4 BP tests. The screen says 捕捉1隻… with the digit 1, while the dictionary has 捕捉一隻… with the character 一. The fuzzy match accepts this, and the test now covers it.

Running these needs the PaddleOCR detection model ("PaddleOCRDetection" in Settings → Resources), the same as Chinese OCR in the app.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E

dayfine and others added 2 commits October 20, 2026 19:31
The Blueberry Points crop ended at x=0.957, which included the left
stroke of the "B" in the "BP" suffix. PaddleOCR read it as an extra
digit, so a balance of 6750 came back as 67501.

Narrow the crop to end at x=0.954 and move the reader into
Inference/PokemonSV_BlueberryPointsReader so it can be tested from a
captured frame without depending on the BBQ program code. read_BP()
still opens and closes the panel and delegates to the shared reader.

Add two full-frame reference screenshots (6750 and 6740 BP, taken one
reroll apart) and register four PokemonSV::BlueberryPoints unit tests
at 1920x1080 and 1280x720. With the old crop restored, all four fail.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
The two Traditional Chinese quest panel frames added for the BP reader
also show three quests each. Read every slot at 1080p and 720p, and
check that the empty fourth slot reads as nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine

dayfine commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Closing for now to keep the upstream queue to PRs that are ready: this one waits on unmerged parent PRs. It continues on my fork as dayfine#7, and I'll reopen it here once its parents merge.

@dayfine dayfine closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant