Repository navigation
Nuke the dead audio stream conversion kernels, TimeSample tools, and sandbox fossils - #1699
Merged
Merged
Conversation
Follow-up to the StreamHistory migration (#1695) and the legacy float path removal (#1698); two pieces of the old audio stack are now unreferenced: - Kernels/AudioStreamConversion: the convert_audio_* raw sample-format kernels. The only call site in the tree was a #if 0 block in TestProgramComputer (removed with the include); the live pipeline converts formats through Kernels/AudioStreamConverter instead. - AudioPipeline/Tools/TimeSampleBuffer, TimeSampleBufferReader and TimeSampleWriter: the old fault-tolerant timestamped sample buffer the pre-migration stream history recording rode on. No references remain anywhere in the source. Both are dropped from SourceFiles.cmake; TestProgramComputer also loses its stale StreamConverters.h include (the header itself is kept - AudioInputDevice inherits from MisalignedStreamConverter / ObjectStreamListener). Full suite: 18,276 passed / 0 failed / 0 skipped.
The dev sandbox kept early versions of the pre-pipeline audio classes. Remove the #if 0 block using the long-deleted AudioSourceReader / AudioListener / AudioSampleFormat (plus the commented-out AudioStreamReader2 line) and the stale AudioConstants.h include (none of its constants are used in the file). The sandbox's #if 0 blocks that exercise the current kernels are left in place. Full suite: 18,276 passed / 0 failed / 0 skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the StreamHistory migration (#1695) and the legacy float path removal (#1698). Three pieces of the old audio stack are now unreferenced:
Kernels/AudioStreamConversion/(commit 1) - theconvert_audio_*raw sample-format kernels (default + x86 SSE41 core). The only call site in the tree was a#if 0smoke-test block inTestProgramComputer. Nuked the dir, the cmake entries, and that block + include.Kernels/AudioStreamConverter(the similar name) is untouched - still used byRawAudio2WorkingAudio/WorkingAudio2RawAudio.AudioPipeline/Tools/TimeSample*(commit 1) -TimeSampleBuffer,TimeSampleBufferReader,TimeSampleWriter: the old fault-tolerant timestamped sample buffer the pre-migration stream-history recording rode on. Zero references anywhere.TestProgramComputersandbox fossils (commit 2, on request) - the dev sandbox kept early versions of the pre-pipeline audio classes: the#if 0block using the long-deletedAudioSourceReader/AudioListener/AudioSampleFormat, the commented-outAudioStreamReader2line, and a staleAudioConstants.hinclude (none of its constants are used in the file). The sandbox's#if 0blocks that exercise the current kernels are left in place.Both cmake drops plus the stale
StreamConverters.hinclude inTestProgramComputer(the header itself is kept -AudioInputDeviceinherits fromMisalignedStreamConverter/ObjectStreamListener) are in commit 1.Walked the rest of the audio stack; everything else is live or scheduled for the B/C/D steps (
AudioSourceraw API,AudioInfoincl. the legacysupported_formats()the widget still uses,AudioOption/AudioSelectorWidget,AudioFeed,AudioTemplate,AudioConstants, spectrum + UI all referenced;AudioSession/AudioPassthroughPairlean post-#1698).Verified:
-Werrorclean (incl. the modified sandbox file), full suite 18,276 / 0 / 0 on both commits (= main baseline; no test count change).