Skip to content

Nuke the dead audio stream conversion kernels, TimeSample tools, and sandbox fossils - #1699

Merged
Mysticial merged 2 commits into
mainfrom
nuke-audiostreamconversion
Oct 24, 2026
Merged

Mysticial merged 2 commits into
mainfrom
nuke-audiostreamconversion

Conversation

@pa-devbot

@pa-devbot pa-devbot commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to the StreamHistory migration (#1695) and the legacy float path removal (#1698). Three pieces of the old audio stack are now unreferenced:

Kernels/AudioStreamConversion/ (commit 1) - the convert_audio_* raw sample-format kernels (default + x86 SSE41 core). The only call site in the tree was a #if 0 smoke-test block in TestProgramComputer. Nuked the dir, the cmake entries, and that block + include. Kernels/AudioStreamConverter (the similar name) is untouched - still used by RawAudio2WorkingAudio/WorkingAudio2RawAudio.

AudioPipeline/Tools/TimeSample* (commit 1) - TimeSampleBuffer, TimeSampleBufferReader, TimeSampleWriter: the old fault-tolerant timestamped sample buffer the pre-migration stream-history recording rode on. Zero references anywhere.

TestProgramComputer sandbox fossils (commit 2, on request) - the dev sandbox kept early versions of the pre-pipeline audio classes: the #if 0 block using the long-deleted AudioSourceReader/AudioListener/AudioSampleFormat, the commented-out AudioStreamReader2 line, and a stale AudioConstants.h include (none of its constants are used in the file). The sandbox's #if 0 blocks that exercise the current kernels are left in place.

Both cmake drops plus the stale StreamConverters.h include in TestProgramComputer (the header itself is kept - AudioInputDevice inherits from MisalignedStreamConverter/ObjectStreamListener) are in commit 1.

Walked the rest of the audio stack; everything else is live or scheduled for the B/C/D steps (AudioSource raw API, AudioInfo incl. the legacy supported_formats() the widget still uses, AudioOption/AudioSelectorWidget, AudioFeed, AudioTemplate, AudioConstants, spectrum + UI all referenced; AudioSession/AudioPassthroughPair lean post-#1698).

Verified: -Werror clean (incl. the modified sandbox file), full suite 18,276 / 0 / 0 on both commits (= main baseline; no test count change).

Follow-up to the StreamHistory migration (#1695) and the legacy float
path removal (#1698); two pieces of the old audio stack are now
unreferenced:

- Kernels/AudioStreamConversion: the convert_audio_* raw sample-format
  kernels. The only call site in the tree was a #if 0 block in
  TestProgramComputer (removed with the include); the live pipeline
  converts formats through Kernels/AudioStreamConverter instead.
- AudioPipeline/Tools/TimeSampleBuffer, TimeSampleBufferReader and
  TimeSampleWriter: the old fault-tolerant timestamped sample buffer
  the pre-migration stream history recording rode on. No references
  remain anywhere in the source.

Both are dropped from SourceFiles.cmake; TestProgramComputer also
loses its stale StreamConverters.h include (the header itself is kept -
AudioInputDevice inherits from MisalignedStreamConverter /
ObjectStreamListener).

Full suite: 18,276 passed / 0 failed / 0 skipped.
The dev sandbox kept early versions of the pre-pipeline audio classes.
Remove the #if 0 block using the long-deleted AudioSourceReader /
AudioListener / AudioSampleFormat (plus the commented-out
AudioStreamReader2 line) and the stale AudioConstants.h include (none
of its constants are used in the file). The sandbox's #if 0 blocks that
exercise the current kernels are left in place.

Full suite: 18,276 passed / 0 failed / 0 skipped.
@pa-devbot pa-devbot changed the title Nuke the dead audio stream conversion kernels and TimeSample tools Nuke the dead audio stream conversion kernels, TimeSample tools, and sandbox fossils Oct 24, 2026
@Mysticial
Mysticial merged commit d495988 into main Oct 24, 2026
7 checks passed
@Mysticial
Mysticial deleted the nuke-audiostreamconversion branch October 24, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants