Repository navigation
Sockets: rename the server's private close() to close_and_wait() - #1865
Merged
Merged
Conversation
Mirrors the ClientSocket naming, per review of #1864: the private blocking teardown in ServerSocket_POSIX, ServerSocket_WinSocket and ServerSocket_Qt is now close_and_wait() (destructor-only), and the comments and docs that referred to it as close() are updated. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1864 (per its review): in the server classes, rename the private
close()toclose_and_wait()to mirror the client classes, which haveclose()(public, non-blocking) +close_and_wait()(private, blocking).Pure rename, no behaviour change:
ServerSocket_POSIX,ServerSocket_WinSocket,ServerSocket_Qt: the private destructor-only blocking teardown is nowclose_and_wait(); the destructors call it.close()are updated (AbstractServerSocket.h, the three backends' headers/sources - e.g. theDESTRUCTING-preservation note inServerSocket_Qt::on_close_connection()and the "close_and_wait() joins the whole list" notes).close_connection()is untouched.Verification: full local run, 0 failures; all 27 socket tests pass.