Repository navigation
PokemonHome box selection arrow detection improvements - #1869
Merged
Merged
Conversation
Dalton-V
marked this pull request as ready for review
November 8, 2026 15:30
This was referenced Nov 9, 2026
Dalton-V
force-pushed
the
home-selection-arrow
branch
from
November 10, 2026 02:55
27e013b to
409cc41
Compare
Member
Author
|
I forgot to upload the new arrow resources.. PokemonAutomation/Packages#92 |
Dalton-V
force-pushed
the
home-selection-arrow
branch
from
November 10, 2026 13:38
409cc41 to
977f56c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PokemonHome SelectionArrowDetector is not currently used.
To know the current mode we check the color of the square at the top of the screen.
To navigate to the first slot of the box we move through each slot attempting to detect the red of the arrow in the first slot each movement. This means we might do 29 movements and detections just to navigate to the first slot.
I've updated the arrow detector to have a similar return object to the recently added FRLG BoxSelection Detector.
Now we can handle any of the selection modes (Red, Blue, Green) instead of just Red. The detector returns the location of the cursor (Grid, or one of the buttons). This allows for quicker navigation and better blind movement and validation.
This is also a prerequisite of navigating through the page view.
The Selection Arrow Detector is still not used from this change.
Test Files: PokemonAutomation/CommandLineTests#44