Repository navigation
[SwSh MaxLair] Dedup two of the same type in summary read - #1882
Merged
Mysticial merged 1 commit intoNov 10, 2026
Merged
Conversation
The "O" of the summary's "NORMAL" type label also matches the Normal icon, so a single-type Normal opponent read as Normal/Normal and matched nothing; a type read twice is now one type. Adds an image test on a Persian summary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the two types read from summary are the same, drop the second one (keep it NONE).
Otherwise two of the same type won't be able to match with any pokemon, resulting in an empty opponent from summary reads when that happens.
This is only an issue in some languages but not others, e.g. in English, the O in NORMAL might be matched as the normal type symbol and produce two
NORMALreads.Test image: PokemonAutomation/CommandLineTests#45.
Discovered in #1851 (comment)