Skip to content

[SwSh MaxLair] Dedup two of the same type in summary read - #1882

Merged
Mysticial merged 1 commit into
PokemonAutomation:mainfrom
dayfine:upstream/maxlair-single-type
Nov 10, 2026
Merged

Mysticial merged 1 commit into
PokemonAutomation:mainfrom
dayfine:upstream/maxlair-single-type

Conversation

@dayfine

@dayfine dayfine commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

When the two types read from summary are the same, drop the second one (keep it NONE).

Otherwise two of the same type won't be able to match with any pokemon, resulting in an empty opponent from summary reads when that happens.

This is only an issue in some languages but not others, e.g. in English, the O in NORMAL might be matched as the normal type symbol and produce two NORMAL reads.

Test image: PokemonAutomation/CommandLineTests#45.

Discovered in #1851 (comment)

The "O" of the summary's "NORMAL" type label also matches the Normal icon, so
a single-type Normal opponent read as Normal/Normal and matched nothing; a
type read twice is now one type. Adds an image test on a Persian summary.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
@Mysticial
Mysticial merged commit 9f19ad7 into PokemonAutomation:main Nov 10, 2026
8 checks passed
@dayfine
dayfine deleted the upstream/maxlair-single-type branch November 10, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants