Repository navigation
Common: S2 OEM state + PABotBase2 NS2 message headers (CC-side copies) - #1885
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC-side copies of the S2 OEM controller shared files, mirroring Firmware PR PokemonAutomation/Firmware#56:
Common/PABotBase2/Controllers/PABotBase2_Controller_NS2_OemController.h- the PABotBase2 NS2 serial messages (0xa0-0xa4), byte-identical to the Firmware-side header.Common/ControllerStates/NintendoSwitch2_OemController_State.h/.cpp- the S2 report structs from Firmware PR Linux #55, which landed without the CC-side copy. Now included so the NS2 message header's include resolves.SerialPrograms/cmake/SourceFiles.cmake- entries for the three files above.All files are byte-identical to their Firmware counterparts. The NS2 header is syntax-checked on the host with the CC-side include paths; no CC code references the messages yet (the S2 host-side CC module comes with the S2 workstream).