Skip to content

Common: S2 OEM state + PABotBase2 NS2 message headers (CC-side copies) - #1885

Merged
Mysticial merged 4 commits into
mainfrom
s2-oem-controller-messages
Nov 11, 2026
Merged

Mysticial merged 4 commits into
mainfrom
s2-oem-controller-messages

Conversation

@pa-devbot

Copy link
Copy Markdown
Collaborator

CC-side copies of the S2 OEM controller shared files, mirroring Firmware PR PokemonAutomation/Firmware#56:

  • Common/PABotBase2/Controllers/PABotBase2_Controller_NS2_OemController.h - the PABotBase2 NS2 serial messages (0xa0-0xa4), byte-identical to the Firmware-side header.
  • Common/ControllerStates/NintendoSwitch2_OemController_State.h / .cpp - the S2 report structs from Firmware PR Linux #55, which landed without the CC-side copy. Now included so the NS2 message header's include resolves.
  • SerialPrograms/cmake/SourceFiles.cmake - entries for the three files above.

All files are byte-identical to their Firmware counterparts. The NS2 header is syntax-checked on the host with the CC-side include paths; no CC code references the messages yet (the S2 host-side CC module comes with the S2 workstream).

@Mysticial
Mysticial marked this pull request as ready for review November 11, 2026 03:54
@Mysticial
Mysticial merged commit f0098f1 into main Nov 11, 2026
15 checks passed
@Mysticial
Mysticial deleted the s2-oem-controller-messages branch November 11, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants