Repository navigation
PokemonFRLG: battle move choice - #1889
Open
thewhitewolfking wants to merge 1 commit into
Open
thewhitewolfking wants to merge 1 commit into
thewhitewolfking wants to merge 1 commit into
Conversation
Dalton-V
reviewed
Nov 11, 2026
| logger.log("Battling Pokemon's level: " + std::to_string(level)); | ||
| return level; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Please add tests for new inference
| ImageViewRGB32 game_screen = extract_box_reference(frame, GameSettings::instance().GAME_BOX); | ||
| ImageViewRGB32 box = extract_box_reference(game_screen, m_own_level_box); | ||
|
|
||
| // "Lv" and digits, the same in every language: read as English. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Second split-up piece of #1887: choosing and using moves in battle. Nothing uses it yet (EXP Farmer will). Needs the data in PokemonAutomation/Packages#93.
Language changes from #1887: no English text is read anymore. A move that can't be used is detected by the message waiting for a button right after the move is chosen. (Before, it read "disabled" in English.) That detection isn't tested on hardware yet.
Still to do in a later PR: the rest of the battle loop (yes/no prompts, level tracking, Grudge message, end of battle) still reads English text in #1887. Open to suggestions on how you'd like that handled.