Repository navigation
Add command-line test for PokemonSV_ItemPrinterJobsDetector - #1890
Merged
Merged
Conversation
Adds the Item Printer material selection screen (Japanese, print count 1) as a test image and a unit test case expecting detect_jobs() to return 1. The test image is added in PokemonAutomation/CommandLineTests (PR #46); until that is merged, this test fails with a missing file. The detector is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a command-line test case for the Item Printer jobs detector, using the material selection screen attached in Discord (Japanese, print count 1, 3 BP).
PokemonSV/ItemPrinterJobsDetector/Japanese_Jobs_1.pngin the CommandLineTests repo (PR PokemonSV: Item Printer jobs detector test screen (Japanese, 1 job) CommandLineTests#46) - the test will fail with a missing file in CI until that PR is merged.Test_ItemPrinterJobsDetector(ImageUnitTest) runsdetect_jobs()on the image and expects 1 job, with the PaddleOCR single-line memory estimate.Verified locally: the test passes on the clean 1080p image (all 20,517 tests pass; also passes with --augment-color-distortions), and the RGB32 range-filter kernels (Default/NEON/SSE42/AVX2/AVX512) produce byte-identical outputs on this crop.