Repository navigation
Add 10-job test case for PokemonSV_ItemPrinterJobsDetector - #1891
Merged
Merged
Conversation
Adds the 10-print material selection screen (Japanese, 打印回数 10回, 30 BP) as a second test image expecting detect_jobs() == 10. The image lives in PokemonAutomation/CommandLineTests (new PR); until it is merged, this test fails with a missing file in CI. Verified locally: both Item Printer jobs detector tests pass (20,518 passed, 0 failed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a second command-line test case for the Item Printer jobs detector, using the 10-print screen attached in Discord (Japanese, 打印回数 10回, 30 BP).
PokemonSV/ItemPrinterJobsDetector/Japanese_Jobs_10.pngin the CommandLineTests repo (PR below) - the test fails with a missing file in CI until that PR merges.detect_jobs()to return 10.Verified locally: both Item Printer jobs detector tests pass (20,518 passed, 0 failed in the full pa-test run).