Skip to content

Add 10-job test case for PokemonSV_ItemPrinterJobsDetector - #1891

Merged
jw098 merged 1 commit into
mainfrom
item-printer-jobs-detector-test-10
Nov 11, 2026
Merged

jw098 merged 1 commit into
mainfrom
item-printer-jobs-detector-test-10

Conversation

@pa-devbot

Copy link
Copy Markdown
Collaborator

Adds a second command-line test case for the Item Printer jobs detector, using the 10-print screen attached in Discord (Japanese, 打印回数 10回, 30 BP).

  • Test image: PokemonSV/ItemPrinterJobsDetector/Japanese_Jobs_10.png in the CommandLineTests repo (PR below) - the test fails with a missing file in CI until that PR merges.
  • Expects detect_jobs() to return 10.
  • Detector code unchanged.

Verified locally: both Item Printer jobs detector tests pass (20,518 passed, 0 failed in the full pa-test run).

Adds the 10-print material selection screen (Japanese, 打印回数 10回,
30 BP) as a second test image expecting detect_jobs() == 10. The image
lives in PokemonAutomation/CommandLineTests (new PR); until it is
merged, this test fails with a missing file in CI.

Verified locally: both Item Printer jobs detector tests pass
(20,518 passed, 0 failed).
@jw098
jw098 merged commit f5d3876 into main Nov 11, 2026
8 checks passed
@jw098
jw098 deleted the item-printer-jobs-detector-test-10 branch November 11, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants