Repository navigation
Remove unused SerialPABotBase 1 message protocol headers - #1892
Merged
Merged
Conversation
The PABotBase 1 message headers in Common/SerialPABotBase/ are no longer included by any code: - SerialPABotBase_Messages_HID_Keyboard.h - SerialPABotBase_Messages_NS1_OemControllers.h - SerialPABotBase_Messages_NS_WiredController.h - SerialPABotBase_Protocol.h (its only remaining reference was a stale #include in TestProgramComputer.cpp; the sole use of its seqnum_t type is inside an #if 0 block) SerialPABotBase_Protocol_IDs.h is kept: its PABB_PID_*/PABB_CID_* macros are still used by the PABotBase2 connection code (PABotBase2_DeviceHandle.cpp, SerialPABotBase.h/.cpp, NintendoSwitch_PABotBase2_WiredController.cpp, StandardHid_Keyboard_PABotBase2.cpp). Also removes the deleted files from the CoreLib source list in SerialPrograms/cmake/SourceFiles.cmake. The equivalent files in the Firmware repo are left in place until PABotBase 1 support is fully removed from firmware.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PABotBase 1 message headers in
Common/SerialPABotBase/are no longer included by any code in Arduino-Source:SerialPABotBase_Messages_HID_Keyboard.hSerialPABotBase_Messages_NS1_OemControllers.hSerialPABotBase_Messages_NS_WiredController.hSerialPABotBase_Protocol.hNothing
#includes the three message headers anywhere; they only appeared in the CoreLib source list inSerialPrograms/cmake/SourceFiles.cmake, which is also updated here.SerialPABotBase_Protocol.hhad one remaining reference: a stale#includeinSerialPrograms/Source/NintendoSwitch/DevPrograms/TestProgramComputer.cpp. The only identifier used from it (seqnum_t) appears in an#if 0block in that file, so the include is removed.Kept:
SerialPABotBase_Protocol_IDs.h— itsPABB_PID_*/PABB_CID_*macros are still used by the PABotBase 2 connection code (PABotBase2_DeviceHandle.cpp,SerialPABotBase.h/.cpp,NintendoSwitch_PABotBase2_WiredController.cpp,StandardHid_Keyboard_PABotBase2.cpp).The same headers still exist in the Firmware repo and are left untouched there, since PABotBase 1 support hasn't been fully removed from firmware yet.
Verified with a full Linux CI-style build (
pa-build, CMake+Ninja, RelWithDebInfo): compiles and links cleanly, includingTestProgramComputer.cppwith the include removed.