Repository navigation
[SwSh MaxLair] Recover the boss from the summary when header read is not a boss - #1894
Merged
Mysticial merged 1 commit intoNov 13, 2026
Merged
Conversation
Prevent an OCR misread from making a non-boss as boss during boss battle. - Leave the boss empty in header read if not GlobalState::opponent_fits_stage() in process_header_read - Retry the OCR in summary read, which makes a valid boss string more likely - accept_opponent() then only records a valid boss - boss_if_caught() returns the boss only after the fourth win - If the boss is still empty, throw (same as before) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
MajorLOL
added a commit
to MajorLOL/Arduino-Source
that referenced
this pull request
Nov 13, 2026
72de561 Sockets: add a per-connection id to server socket sends (PokemonAutomation#1910) 8d67694 Home - Detect Selection Hand (PokemonAutomation#1903) e5b3172 Support different game languages (PokemonAutomation#1904) (the FRLG Box Sorter) 14cf718 Recover the boss from the summary when header read is not a boss (PokemonAutomation#1894) No conflicts; none of them touches the AutoStory. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AFpKyhKsEg9bJNoPWQzjJJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent an OCR misread from making a non-boss as boss during boss battle
#1851 followup
GlobalState::opponent_fits_stage()inprocess_header_readaccept_opponent()then only records a valid bossboss_if_caught()returns the boss only after the fourth winNote: currently
boss_ballfor BossFinder fails wheneverboss_slugis not a boss (given it's not in the table), so either a misread or an empty string fails it.