Skip to content

FRLG: remove tests for navigation behavior - #1896

Merged
theastrogoth merged 1 commit into
PokemonAutomation:mainfrom
theastrogoth:frlg-tests
Nov 12, 2026
Merged

theastrogoth merged 1 commit into
PokemonAutomation:mainfrom
theastrogoth:frlg-tests

Conversation

@theastrogoth

Copy link
Copy Markdown
Contributor

Takes out the tests for FRLG navigation added in #1663. Typically tests aren't written for program behavior in this way, and testing is done directly on a Switch instead. Removing them helps to avoid more tests of this kind being written and submitted by contributors using AI.

@theastrogoth
theastrogoth merged commit aa5a927 into PokemonAutomation:main Nov 12, 2026
8 checks passed
@theastrogoth
theastrogoth deleted the frlg-tests branch November 12, 2026 01:17
dayfine added a commit to dayfine/Arduino-Source that referenced this pull request Nov 12, 2026
…tion#1896

Upstream removed scripted navigation behavior tests (PokemonAutomation#1896). Follow it:
take its Navigation and Tests files, drop PartyCheckActions, the image
overload of detect_last_occupied_party_slot and the party check tests,
and run the check directly in start_program_game_checks().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit to dayfine/Arduino-Source that referenced this pull request Nov 14, 2026
PokemonFRLG_Tests.cpp: take upstream PokemonAutomation#1896's removal of the exit_wild_battle tests (engine carries it); keep this branch's reader and detector tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit to dayfine/Arduino-Source that referenced this pull request Nov 14, 2026
PokemonFRLG_Tests.cpp: take upstream PokemonAutomation#1896's removal of the exit_wild_battle tests; keep the Overworld tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit to dayfine/Arduino-Source that referenced this pull request Nov 14, 2026
PokemonFRLG_Tests.cpp: take upstream PokemonAutomation#1896's removal of the exit_wild_battle tests; keep this branch's tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit to dayfine/Arduino-Source that referenced this pull request Nov 14, 2026
PokemonFRLG_Tests.cpp: take upstream PokemonAutomation#1896's removal of the exit_wild_battle tests; keep this branch's tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit to dayfine/Arduino-Source that referenced this pull request Nov 14, 2026
PokemonFRLG_Tests.cpp: take upstream PokemonAutomation#1896's removal of the exit_wild_battle tests; keep this branch's tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit to dayfine/Arduino-Source that referenced this pull request Nov 14, 2026
Takes PokemonAutomation#1896's PokemonFRLG_Navigation and EggRng from the parent, undoing
d11b360's keep of the old copies. OverworldSim.h: this branch's gate
additions with the ScreenEvents include from CommonTools, in the file's LF
endings. AutoStoryScreenEvents_Tests.cpp: the parent's version.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit to dayfine/Arduino-Source that referenced this pull request Nov 14, 2026
Takes the parent's PokemonFRLG_Navigation and EggRng (PokemonAutomation#1896's), replacing
the old copies kept through d11b360. OverworldSim.h: the parent's file
with this branch's land_fallen_boulder(), in LF endings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine added a commit to dayfine/Arduino-Source that referenced this pull request Nov 14, 2026
Brings PokemonAutomation#1896's PokemonFRLG_Navigation down the stack. ScreenEvents.cpp:
the parent's dark-cave check (f6080f0). StepInterrupts: this branch's
failure-frame guard.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant