Repository navigation
FRLG: remove tests for navigation behavior - #1896
Merged
Merged
Conversation
dayfine
added a commit
to dayfine/Arduino-Source
that referenced
this pull request
Nov 12, 2026
…tion#1896 Upstream removed scripted navigation behavior tests (PokemonAutomation#1896). Follow it: take its Navigation and Tests files, drop PartyCheckActions, the image overload of detect_last_occupied_party_slot and the party check tests, and run the check directly in start_program_game_checks(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
to dayfine/Arduino-Source
that referenced
this pull request
Nov 14, 2026
PokemonFRLG_Tests.cpp: take upstream PokemonAutomation#1896's removal of the exit_wild_battle tests (engine carries it); keep this branch's reader and detector tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
to dayfine/Arduino-Source
that referenced
this pull request
Nov 14, 2026
PokemonFRLG_Tests.cpp: take upstream PokemonAutomation#1896's removal of the exit_wild_battle tests; keep the Overworld tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
to dayfine/Arduino-Source
that referenced
this pull request
Nov 14, 2026
PokemonFRLG_Tests.cpp: take upstream PokemonAutomation#1896's removal of the exit_wild_battle tests; keep this branch's tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
to dayfine/Arduino-Source
that referenced
this pull request
Nov 14, 2026
PokemonFRLG_Tests.cpp: take upstream PokemonAutomation#1896's removal of the exit_wild_battle tests; keep this branch's tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
to dayfine/Arduino-Source
that referenced
this pull request
Nov 14, 2026
PokemonFRLG_Tests.cpp: take upstream PokemonAutomation#1896's removal of the exit_wild_battle tests; keep this branch's tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
to dayfine/Arduino-Source
that referenced
this pull request
Nov 14, 2026
Takes PokemonAutomation#1896's PokemonFRLG_Navigation and EggRng from the parent, undoing d11b360's keep of the old copies. OverworldSim.h: this branch's gate additions with the ScreenEvents include from CommonTools, in the file's LF endings. AutoStoryScreenEvents_Tests.cpp: the parent's version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
to dayfine/Arduino-Source
that referenced
this pull request
Nov 14, 2026
Takes the parent's PokemonFRLG_Navigation and EggRng (PokemonAutomation#1896's), replacing the old copies kept through d11b360. OverworldSim.h: the parent's file with this branch's land_fallen_boulder(), in LF endings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
dayfine
added a commit
to dayfine/Arduino-Source
that referenced
this pull request
Nov 14, 2026
Brings PokemonAutomation#1896's PokemonFRLG_Navigation down the stack. ScreenEvents.cpp: the parent's dark-cave check (f6080f0). StepInterrupts: this branch's failure-frame guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VUubhHeYSMGSSDXZkKZss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes out the tests for FRLG navigation added in #1663. Typically tests aren't written for program behavior in this way, and testing is done directly on a Switch instead. Removing them helps to avoid more tests of this kind being written and submitted by contributors using AI.