Repository navigation
FRLG SpriteReader fixes and tests - #1913
Merged
theastrogoth merged 2 commits intoNov 13, 2026
Merged
Conversation
Dalton-V
approved these changes
Nov 13, 2026
MajorLOL
added a commit
to MajorLOL/Arduino-Source
that referenced
this pull request
Nov 14, 2026
39f94a9 FRLG SpriteReader fixes and tests (PokemonAutomation#1913) 73fecab FRLG Box Sorter - BallReader (PokemonAutomation#1908) No conflicts (PokemonFRLG_WildEncounterReader.cpp changed on both sides, in different places); neither touches the AutoStory. All 102 sources of VideoGames/PokemonFRLG compile on the merged tree. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AFpKyhKsEg9bJNoPWQzjJJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the FRLG Sprite Reader, which was my attempt at handling Nidoran genders before the fix that reads the gender characters. It lacked tests and was sometimes unreliable due to how sprites "bounce" when the summary screen is opened.
This does the following:
SpriteDatabase(Summary sprites are usually mirrored)StatsReaderandWildEncounterReaderNote to self -- remember to delete the old sprite sheet and duplicate test image after this is merged