Skip to content

FRLG SpriteReader fixes and tests - #1913

Merged
theastrogoth merged 2 commits into
PokemonAutomation:mainfrom
theastrogoth:frlg-sprite-reader
Nov 13, 2026
Merged

theastrogoth merged 2 commits into
PokemonAutomation:mainfrom
theastrogoth:frlg-sprite-reader

Conversation

@theastrogoth

@theastrogoth theastrogoth commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

This fixes the FRLG Sprite Reader, which was my attempt at handling Nidoran genders before the fix that reads the gender characters. It lacked tests and was sometimes unreliable due to how sprites "bounce" when the summary screen is opened.

This does the following:

  • adds an option to mirror sprites horizontally in SpriteDatabase (Summary sprites are usually mirrored)
  • adds a way to test several windows over the sprite on the screen, shifting a GBA pixel at a time
  • adds a sprite reader for battles, which is currently unused but might useful as a fallback for a failed name read or problem with audio detection
  • has the sprite reader return a slug with form info to differentiate between Unown forms (possibly helpful for box sorters?)
  • reuses test images for the StatsReader and WildEncounterReader

Note to self -- remember to delete the old sprite sheet and duplicate test image after this is merged

@theastrogoth
theastrogoth merged commit 39f94a9 into PokemonAutomation:main Nov 13, 2026
8 checks passed
@theastrogoth
theastrogoth deleted the frlg-sprite-reader branch November 13, 2026 23:07
MajorLOL added a commit to MajorLOL/Arduino-Source that referenced this pull request Nov 14, 2026
39f94a9 FRLG SpriteReader fixes and tests (PokemonAutomation#1913)
73fecab FRLG Box Sorter - BallReader (PokemonAutomation#1908)

No conflicts (PokemonFRLG_WildEncounterReader.cpp changed on both sides, in
different places); neither touches the AutoStory. All 102 sources of
VideoGames/PokemonFRLG compile on the merged tree.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AFpKyhKsEg9bJNoPWQzjJJ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants