Improve precompiles weight - #2013
Draft
HenriqueNogara wants to merge 2 commits into
Draft
HenriqueNogara wants to merge 2 commits into
HenriqueNogara wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The benchmark undercharges worst-case compliance checks, and the incorrect best-case weight makes the refund branch unreachable.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Improves NFT transfer-report weights and ERC-7943 canTransfer gas accounting, with synchronized version updates.
Changes:
- Adds NFT transfer-report benchmarks and generated weights.
- Updates NFT precompile gas calculations.
- Bumps package and runtime versions.
| File | Summary |
|---|---|
pallets/weights/src/pallet_nft.rs |
Adds generated NFT transfer-report weights. |
pallets/runtime/testnet/src/runtime.rs |
Updates runtime spec version. |
pallets/runtime/mainnet/src/runtime.rs |
Updates runtime spec version. |
pallets/runtime/develop/src/runtime.rs |
Updates runtime spec version. |
pallets/precompiles/src/interface/nft/erc7943.rs |
Updates gas accounting; best-case weight selection requires correction. |
pallets/nft/src/lib.rs |
Extends the NFT weight interface. |
pallets/nft/src/benchmarking.rs |
Adds transfer-report benchmarks; worst-case compliance traversal is not exercised. |
Cargo.toml |
Updates package version. |
Cargo.lock |
Updates locked package version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+394
to
+396
| // Max Statistics and Compliance rules are set | ||
| let (asset_id, sender, receiver, _) = | ||
| setup_nft_transfer::<T>(&alice, &bob, 1, None, None, false, 0, false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog
other