Skip to content

ci: add ECR publish and resolve SonarCloud issues - #373

Merged
polymesh-bot merged 2 commits into
alphafrom
ci/ecr-publish-alpha
Sep 18, 2026
Merged

polymesh-bot merged 2 commits into
alphafrom
ci/ecr-publish-alpha

Conversation

@prashantasdeveloper

Copy link
Copy Markdown
Contributor

Summary

  • Cherry-picks 27fee54 from `master` (`ci: add ECR publish alongside Docker Hub`): replaces `docker-image.yml` with `build-publish-image.yml`, which publishes to ECR as well as Docker Hub.
  • Fixes the SonarCloud quality gate failures reported on Release all changes to master #372:
    • Marks the `PortfoliosController` logger as `readonly` (typescript:S2933).
    • Moves the duplicated Identity setup in the `registerIdentity`/`registerDid` specs of `identities.controller.spec.ts` into a shared helper. This clears the new duplicated lines density check.

Test plan

  • `eslint` and `tsc --noEmit` pass
  • Identities and portfolios jest suites pass (82 tests)
  • SonarCloud quality gate passes on this PR

🤖 Generated with Claude Code

debelio and others added 2 commits September 18, 2026 15:44
Mark the PortfoliosController logger as readonly and extract the duplicated
Identity setup in the registerIdentity/registerDid controller specs into a
shared helper.
@sonarqubecloud

Copy link
Copy Markdown

@prashantasdeveloper

Copy link
Copy Markdown
Contributor Author

/fast-forward

@polymesh-bot
polymesh-bot merged commit 0a24090 into alpha Sep 18, 2026
10 checks passed
@polymesh-bot
polymesh-bot deleted the ci/ecr-publish-alpha branch September 18, 2026 10:30
@polymesh-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 9.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants