Fix CREATE EXTENSION on PG16+ without a superuser (RDS/Aurora) (#14)

[jnasbyupgrade]

CREATE EXTENSION test_factory fails on PostgreSQL 16+ when installed by a non-superuser role:

ERROR:  must be able to SET ROLE "test_factory__owner"

As of PG16, CREATE ROLE no longer grants the creating role a SET-enabled membership in the new role, so the install's SET ROLE test_factory__owner is rejected. A superuser bypasses the check, so this only surfaces for non-superuser installs (e.g. RDS/Aurora).

Fix: after creating the role, grant it back to the installing role WITH SET, gated on PG16+ (pre-16 GRANT ... TO already permits SET ROLE). The grant is unconditional so it also covers the case where the role already existed.

The failure can't be reproduced under pg_regress, which runs as a superuser, so the added test instead asserts the SET-enabled membership the fix establishes.

Fixes #14

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5b9df93a-c4e9-4e12-9cd7-e30a47e4b9d1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}