Drop the original_role temp table from install (#12/#13)#20
Open
jnasbyupgrade wants to merge 1 commit into
Open
Drop the original_role temp table from install (#12/#13)#20jnasbyupgrade wants to merge 1 commit into
jnasbyupgrade wants to merge 1 commit into
Conversation
…iginal_role temp table from install Both install scripts saved the caller's role in a CREATE TEMP TABLE ... ON COMMIT DROP so they could SET LOCAL ROLE to own objects and restore afterward. That temp table becomes extension-owned, so ON COMMIT DROP conflicts with extension ownership (uninstallable / COMMIT failures, Postgres-Extensions#12/Postgres-Extensions#13), and it collides if the caller already has an original_role temp table. Save the role in a transaction-local GUC via set_config() instead -- no extension-owned object. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit 4c688a472328ad6f2f6eaf1b963e023cf5553d22)
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both install scripts saved the caller's role in a
CREATE TEMP TABLE original_role ON COMMIT DROPso they couldSET LOCAL ROLE test_factory__ownerand restore it afterward. That temp table becomes extension-owned, soON COMMIT DROPconflicts with extension ownership (#12: uninstallable; #13: COMMIT fails), and it also collides if the caller already has anoriginal_roletemp table.Fix: save the caller's role in a transaction-local GUC via
set_config('<ext>.original_role', current_user, true)and restore withSET ROLEat end of script — no extension-owned object, noON COMMIT DROP. Independent of the pgxntool sync (#19); #12/#13 are already closed.