Fix CI so that build failure stops workflow#1619
Closed
SteveL-MSFT wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure the Rust CI workflow stops appropriately when the build/test step fails, preventing downstream steps from attempting to package/upload artifacts that may not exist.
Changes:
- Updates the
continue-on-errorbehavior for the “Build and test with code coverage” step in Linux/macOS/Windows jobs. - Intends to prevent artifact packaging/upload from occurring when the build/test step fails.
Comment on lines
56
to
60
| id: rust-tests | ||
| continue-on-error: true | ||
| continue-on-error: false | ||
| run: ./build.ps1 -Clippy -Test -CodeCoverage -ExcludePesterTests -Verbose | ||
| - name: Upload coverage data | ||
| if: always() |
Comment on lines
148
to
152
| id: rust-tests | ||
| continue-on-error: true | ||
| continue-on-error: false | ||
| run: ./build.ps1 -Clippy -Test -CodeCoverage -ExcludePesterTests -Verbose | ||
| - name: Upload coverage data | ||
| if: always() |
Comment on lines
244
to
248
| id: rust-tests | ||
| continue-on-error: true | ||
| continue-on-error: false | ||
| run: ./build.ps1 -Clippy -Test -CodeCoverage -ExcludePesterTests -Verbose | ||
| - name: Upload coverage data | ||
| if: always() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
CI was incorrectly reporting when it failed. When the build isn't successful, it continues to try to package up the built binaries for CC, but the binaries aren't there since the build failed. Fix is to not have it continue with CC if the build has a failure.