build: adopt PowerShellOrg reusable CI workflow - #497
Open
HeyItsGilbert wants to merge 2 commits into
Open
HeyItsGilbert wants to merge 2 commits into
HeyItsGilbert wants to merge 2 commits into
Conversation
HeyItsGilbert
requested review from
steviecoaster and
vexx32
as code owners
September 18, 2026 00:14
This was referenced Sep 18, 2026
HeyItsGilbert
force-pushed
the
build/reusable-ci-workflow
branch
from
September 18, 2026 00:15
cece4c3 to
1ea60f7
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The caller workflow is missing an explicit permissions: block, which can cause the reusable workflow to fail under read-only default GITHUB_TOKEN permissions.
Pull request overview
Adopts the PowerShellOrg organization-wide reusable GitHub Actions workflow for PSKoans CI by introducing a new .github/workflows/ci.yml that delegates all CI execution to PowerShellOrg/.github/.github/workflows/powershell-ci.yml@main.
Changes:
- Add a new GitHub Actions workflow (
.github/workflows/ci.yml) to run CI on pushes/tags, PRs, and manual dispatch. - Delegate CI execution to the PowerShellOrg reusable workflow (
powershell-ci.yml@main).
File summaries
| File | Description |
|---|---|
| .github/workflows/ci.yml | Adds a new CI workflow that calls the PowerShellOrg reusable CI workflow. |
Review details
Suppressed comments (1)
.github/workflows/ci.yml:16
- Reusable workflows cannot elevate GITHUB_TOKEN permissions; if the repo/org default token permissions are read-only, this call will fail to upload artifacts and publish PR suggestions/test results. Other repos consuming
PowerShellOrg/.github/.github/workflows/powershell-ci.yml@maindeclare explicit workflow-level permissions (e.g., checks/pull-requests write). Add an explicitpermissions:block in this caller workflow.
uses: PowerShellOrg/.github/.github/workflows/powershell-ci.yml@main
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Test Results 4 files 104 suites 1m 38s ⏱️ For more details on these failures, see this check. Results for commit 5aa5f22. ♻️ This comment has been updated with latest results. |
This was referenced Sep 18, 2026
Add .github/workflows/ci.yml calling PowerShellOrg/.github/.github/workflows/powershell-ci.yml@main, which runs ./build.ps1 -Task Test -Bootstrap across Windows PowerShell 5.1, Windows PowerShell 7, Linux PowerShell 7, and macOS PowerShell 7, plus changelog/spell/PSScriptAnalyzer lint checks. pull_request trigger has no branch filter (rather than main-only) so CI runs on every PR in this stack, including intermediate PRs whose base is a feature branch rather than main. Depends on the earlier lowercase tests/ rename in this stack so the reusable workflow's ./tests/out/testResults.xml artifact path resolves on the case-sensitive Linux runner. CI on this PR: Linux/macOS/Windows(PS7) pass. Windows PowerShell 5.1 and the changelog-lint step fail on pre-existing issues this workflow is the first to catch -- tracked as #498 and #499. Refs #488 (do not auto-close; blocked on #498 and #499 for full green CI across all 4 required environments)
HeyItsGilbert
force-pushed
the
build/reusable-ci-workflow
branch
from
September 18, 2026 00:22
1ea60f7 to
a448fed
Compare
Mirrors PSDepend's org-standard workflow set: - publish.yml: calls PowerShellOrg/.github/.github/workflows/powershell-release.yml@main on push to main (and manual dispatch with version/force/dry_run/ create_release/publish overrides) to tag, release, and publish to PSGallery. - stale.yml: daily actions/stale@v9 sweep for inactive issues/PRs, same thresholds and labels as PSDepend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #496 (and #495).
Adds
.github/workflows/ci.ymlcallingPowerShellOrg/.github/.github/workflows/powershell-ci.yml@main, which runs./build.ps1 -Task Test -Bootstrapacross Windows PowerShell 5.1, Windows PowerShell 7, Linux PowerShell 7, and macOS PowerShell 7, plus changelog/spell/PSScriptAnalyzer lint checks.Also adds two more org-standard reusable workflows (mirrored from PSDepend):
.github/workflows/publish.yml-- callspowershell-release.yml@mainon push tomain(plus manual dispatch overrides) to tag, release, and publish to PSGallery..github/workflows/stale.yml-- dailyactions/stale@v9sweep for inactive issues/PRs.Depends on the
tests/lowercase rename in #496 so the reusable workflow's./tests/out/testResults.xmlartifact path resolves on the case-sensitive Linux runner.CI status on this PR: Linux/macOS/Windows (PS7) legs pass. Windows PowerShell 5.1 and the changelog-lint step fail on pre-existing issues this workflow is the first to catch (legacy CI never ran PS5.1 or linted CHANGELOG.md) -- tracked separately as #498 and #499.
Refs #488 -- do not close automatically; #488''s "CI is green on all 4 environments" criterion isn''t met until #498 and #499 land.
Stack: #495 -> #496 -> 3/3