Bug fix: ensure correct parbreaks around image and tabular in sidebyside - #3186
Open
oscarlevin wants to merge 1 commit into
Open
Bug fix: ensure correct parbreaks around image and tabular in sidebyside#3186oscarlevin wants to merge 1 commit into
oscarlevin wants to merge 1 commit into
Conversation
Member
Author
|
Before/after PDFs compared with Adobe's compare tool show only expected diffs (besides a few random "image replaced" with seem to just be artifacts of tikz not being 100% raster-perfect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two related bugs with the latex conversion.
\resizebox{...}{. See the pdf of the sample article corresponding to this Paragraphhttps://pretextbook.org/examples/sample-article/html/section-side-by-side.html#stacking-side-by-side-8-1-3
Claude claimed that the same thing was happening with the text after an image, specifically the text after the QR codes for interactives. This may be, but those QR codes are wide enough that the next word went to the following line anyway. But in theory it does make sense to guard against the "after" case too.