Repository navigation
Conversation
Expose the description and summary containers to the core product refresh, so the combination overrides of the combination_seo feature are displayed when the customer switches combination.
|
Hello @LameuleFR! This is your first pull request on classic-theme repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
js-product-descriptionandjs-product-description-shortclasses to the product description and summary containers (product page and quick view). The core product refresh uses them to display the combination description and summary when the customer switches combination (feature flagcombination_seo, PrestaShop/PrestaShop#43132). Without the flag, nothing changes.The description container is only rendered when the product has a description, so a combination description is not displayed after a switch when the product itself has none.
combination_seofeature flag.2. Fill a description and a summary on one combination of a product that has a description.
3. On the product page, switch between this combination and another one: the description and summary follow the selected combination.