Repository navigation
DCON, RDCON, STRIDE - BUGFIX - Keep the dmlim qlim within qhigh - #328
Merged
Merged
Conversation
With sas_flag, sing_lim moves qlim to (INT(nn*qlim)+dmlim)/nn and steps it back only while it exceeds qmax, so qhigh = 4 with dmlim 0.2 integrates to q = 4.2. Step back while qlim exceeds MIN(qmax,qhigh), as Julia GPEC does since OpenFUSIONToolkit/GPEC#298. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
StuartBenjamin
added a commit
to StuartBenjamin/GPEC-1
that referenced
this pull request
Oct 18, 2026
StuartBenjamin
marked this pull request as draft
October 19, 2026 07:57
StuartBenjamin
marked this pull request as ready for review
October 23, 2026 02:13
matt-pharr
approved these changes
Oct 23, 2026
matt-pharr
left a comment
matt-pharr
left a comment
Collaborator
There was a problem hiding this comment.
This makes sense, I will merge it.
StuartBenjamin
pushed a commit
to StuartBenjamin/GPEC-1
that referenced
this pull request
Oct 23, 2026
PrincetonUniversity#327 PrincetonUniversity#328 PrincetonUniversity#329 PrincetonUniversity#335 merged upstream; + 63328e4 STRIDE naive packing within nIntervalsTot, 0d6b30f docs) into PSFC_dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
sas_flag = t,sing_limmovesqlimto(INT(nn*qlim)+dmlim)/nnand then steps it back only while it exceedsqmax. Aqhighbelowqmaxtherefore does not bound the domain:qhigh = 3.1withdmlim = 0.2integrates to q = 3.2 and keeps the 3/1 surface. This PR steps back whileqlimexceedsMIN(qmax,qhigh), in DCON, RDCON and STRIDE, as Julia GPEC does since OpenFUSIONToolkit/GPEC#298.DIII-D examples with
qhigh = 3.1:DIIID_ideal, 0.2)DIIID_resistive, 0.15)DIIID_resistive, 0.2)The DIII-D, Solov'ev and a10 example decks use
qhigh = 1e3, aboveqmax, so nothing changes for them:DIIID_ideal(DCON) andDIIID_resistive(RDCON) give identical netcdf variables, anddelta_gw.outis identical.🤖 Generated with Claude Code