Repository navigation
PENTRC - BUG FIX - Recover full CGL curvature from perpendicular field strength - #342
Merged
logan-nc merged 1 commit intoOct 22, 2026
Conversation
krystophny
force-pushed
the
fix/pentrc-cgl-curvature-20261020
branch
from
October 21, 2026 13:20
1964e6a to
2380bc6
Compare
krystophny
marked this pull request as ready for review
October 21, 2026 13:22
Contributor
|
Review findings: the fix is correct. Code consistency. Both PENTRC readers impose dB/B = −(∇·ξ⊥ + κ·ξ⊥) with factor 1: Physics.
Runs (develop e80da1e vs 2380bc6, identical DCON/GPEC inputs,
Not blocking (pre-existing): 🤖 Generated with Claude Code |
logan-nc
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pentrc/torque.F90:379 reconstructed curvature with an extra half although
dbob=-(divx+kapx). Remove that half and evaluate the existing 5/3 and 1/3 coefficients inr8; retain the real-Fourier quadratic normalization.This changes results.
Manufactured complex displacement on the existing Solov’ev ideal equilibrium, ψ=0.4:
Im(Tpsi_fcgl)= 2.410379216933e5 → 2.731839412786e5; independent double-adiabatic pressure work gives 2.731839412786e5.Out-of-tree
pentrc_cgl_pressure.f90passes the pressure-work oracle at 1e−10 relative tolerance and rejects develop. Native FortSym checks prove the complex pressure-work and curvature identities.Rebased on develop 24bc45a; focused native GNU Make
dcon gpec pentrcbuild passed locally (gfortran 16.2.1, four jobs). No cluster or gfortran 12.2 build was run.Evidence branch preserves the removed regression and FortSym derivation; commands and results. No added tests, CI targets or docs in this PR.
Chris&AI