Repository navigation
build: put Spotter's own version in Cargo.lock back in step - #19
Merged
Merged
Conversation
In manifest mode release-please bumped Cargo.toml but not the spotter entry of Cargo.lock, so the v0.3.0 release legs, which build with --locked, refused the stale lockfile. Cargo.lock is now an extra file release-please updates, and it says 0.3.0 again.
The rust strategy already bumps the crate's own entry in Cargo.lock: the v0.3.0 release PR missed it only because it was generated before the lockfile was committed and was not regenerated after a hidden build: commit. A second updater on the same file is not needed.
MotherSphere
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.3.0 release run failed in every build leg: the release commit bumped Cargo.toml to 0.3.0 but left the spotter entry of Cargo.lock at 0.2.1, and the legs build with --locked since #18.
Cause: release-please's rust strategy does update Cargo.lock, but the 0.3.0 release PR was generated before Cargo.lock was committed (#18), and a hidden build: commit does not make release-please regenerate an otherwise unchanged release PR. Future release PRs include Cargo.lock.
This sets the spotter entry to 0.3.0. After merge, v0.3.0 (still an empty draft, never published) is moved to the merge commit and rebuilt through the release workflow's recovery dispatch.
Checked locally: cargo build --locked.