fix(manage annotators): Cannot access with AnnotationFileRange change permission

backend/api/models/annotation/annotation_file_range.py

@@ -8,6 +8,7 @@
 
 from backend.aplose.models import User
 from .annotation_task import AnnotationTask
+from ..common.__abstract_permission import AbstractPermission
 from ..data import Spectrogram
 
 
@@ -63,7 +64,7 @@ def filter_editable_by(self, user: User, **kwargs):
         )
 
 
-class AnnotationFileRange(models.Model):
+class AnnotationFileRange(AbstractPermission, models.Model):
     """Gives a range of files to annotate by an annotator within a campaign"""
 
     objects = models.Manager.from_queryset(AnnotationFileRangeQuerySet)()

backend/api/models/annotation/annotation_phase.py

@@ -6,6 +6,7 @@
 
 from backend.api.models.common.__abstract_archivable import AbstractArchivable
 from backend.aplose.models import User
+from .annotation_file_range import AnnotationFileRange
 
 
 class AnnotationPhaseQuerySet(ExtendedQuerySet):
@@ -99,3 +100,8 @@ def has_change_permission(self, user: "User") -> bool:
             or user.id == self.created_by_id
             or user.id == self.annotation_campaign.owner_id
         )
+
+    def has_file_range_change_permission(self, user: "User") -> bool:
+        return self.has_change_permission(
+            user
+        ) and AnnotationFileRange.has_global_change_permission(user)

backend/api/models/common/__abstract_permission.py

@@ -6,10 +6,14 @@ class AbstractPermission(models.Model):
     class Meta:
         abstract = True
 
-    def has_change_permission(self, user: "User") -> bool:
+    @classmethod
+    def has_global_change_permission(cls, user: "User") -> bool:
         edit_permissions = Permission.objects.filter(
             codename__startswith="change",
-            content_type__app_label=self._meta.app_label,
-            content_type__model=self._meta.model_name,
+            content_type__app_label=cls._meta.app_label,
+            content_type__model=cls._meta.model_name,
         ).first()
         return user.has_perm(edit_permissions)
+
+    def has_change_permission(self, user: "User") -> bool:
+        return self.has_global_change_permission(user=user)

backend/api/schema/nodes/annotation_phase.py

@@ -2,6 +2,7 @@
 import graphene_django_optimizer
 from django.db.models import Sum
 from django_extension.schema.types import ExtendedNode
+from graphql import GraphQLResolveInfo
 
 from backend.api.models import AnnotationPhase, AnnotationTask
 from backend.api.schema.enums import AnnotationPhaseType
@@ -78,3 +79,12 @@ def resolve_annotators(self: AnnotationPhase, info):
             ).distinct(),
             info,
         )
+
+    has_file_range_change_permission = graphene.Boolean(required=True)
+
+    @graphene_django_optimizer.resolver_hints()
+    def resolve_has_file_range_change_permission(
+        self: AnnotationPhase, info: GraphQLResolveInfo
+    ):
+        # pylint: disable=not-callable
+        return self.has_file_range_change_permission(info.context.user)

frontend/src/features/AnnotationFileRange/FileRangeActionBar.tsx

@@ -104,7 +104,7 @@ export const FileRangeActionBar: React.FC<{ isPending?: boolean }> = ({ isPendin
                            </Dialog.Root>
                        </div>
 
-                       { phase?.hasChangePermission && <Fragment>
+                       { phase?.hasFileRangeChangePermission && <Fragment>
                            {/* Manage annotators */ }
                            <Popover.Root>
                                <Popover.TriggerLink data-testid="manage"

frontend/src/features/AnnotationPhase/api/annotation-phase.graphql

@@ -9,6 +9,7 @@ query getAnnotationPhase(
         id
         phase
         hasChangePermission
+        hasFileRangeChangePermission
         archived
         hasAnnotations
         tasksCount

frontend/tests/utils/mock/phase.ts

@@ -27,7 +27,8 @@ export const PHASE_QUERIES: {
         userTasksCount,
         archived: phase.archived,
         hasAnnotations: phase.hasAnnotations,
-        hasChangePermission: true
+        hasChangePermission: true,
+        hasFileRangeChangePermission: true,
       },
     },
     managerVerification: {
@@ -41,6 +42,7 @@ export const PHASE_QUERIES: {
         archived: phase.archived,
         hasAnnotations: phase.hasAnnotations,
         hasChangePermission: true,
+        hasFileRangeChangePermission: true,
       },
     },
     Annotation: {
@@ -54,6 +56,7 @@ export const PHASE_QUERIES: {
         archived: phase.archived,
         hasAnnotations: phase.hasAnnotations,
         hasChangePermission: false,
+        hasFileRangeChangePermission: false,
       },
     },
     Verification: {
@@ -67,6 +70,7 @@ export const PHASE_QUERIES: {
         archived: phase.archived,
         hasAnnotations: phase.hasAnnotations,
         hasChangePermission: false,
+        hasFileRangeChangePermission: false,
       },
     },
   },

frontend/tests/utils/mock/types/phase.ts

@@ -1,22 +1,22 @@
 import { type AnnotationPhaseNode } from '../../../../src/api/types.gql-generated';
 
 export type Phase =
-  Omit<AnnotationPhaseNode, 'hasChangePermission' | 'annotationComments' | 'annotationFileRanges' | 'createdBy' | 'annotationTasks' |
-    'annotations' | 'annotationCampaign' | 'endedBy' | 'annotationCampaignId' | 'phase' | 'isEditable' |
-      'isUserAllowedToManage' | 'tasksCount' | 'userTasksCount' | 'userCompletedTasksCount' | 'completedTasksCount' | 'annotators'
-  >
+    Omit<AnnotationPhaseNode, 'hasChangePermission' | 'hasFileRangeChangePermission' | 'annotationComments' | 'annotationFileRanges' | 'createdBy' | 'annotationTasks' |
+        'annotations' | 'annotationCampaign' | 'endedBy' | 'annotationCampaignId' | 'phase' | 'isEditable' |
+        'isUserAllowedToManage' | 'tasksCount' | 'userTasksCount' | 'userCompletedTasksCount' | 'completedTasksCount' | 'annotators'
+    >
 
 export const phase: Phase = {
-  id: '1',
-  createdAt: new Date().toISOString(),
-  archived: false,
-  hasAnnotations: true,
+    id: '1',
+    createdAt: new Date().toISOString(),
+    archived: false,
+    hasAnnotations: true,
 }
 export const otherPhase: Phase = {
-  id: '2',
-  createdAt: new Date().toISOString(),
-  archived: false,
-  hasAnnotations: true,
+    id: '2',
+    createdAt: new Date().toISOString(),
+    archived: false,
+    hasAnnotations: true,
 }
 export const completedTasksCount = 50;
 export const tasksCount = 100;