Repository navigation
Conversation
Collaborator
ElodieENSTA
requested changes
Oct 9, 2026
ElodieENSTA
left a comment
Member
There was a problem hiding this comment.
Maybe raise a higher error if none of the lies could be parsed?
naiscd
approved these changes
Oct 14, 2026
Contributor
Author
Yup, looks like a good idea! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids the raise of an error if some lines of a detection csv file can't be parsed as
Detectioninstances.This is notably the case for APLOSE's weak comments.
Now, the records that can't be parsed are skipped and a warning containing their indexes is logged: