Repository navigation
refactor(capability)!: full names and upper-case acronyms for SketchAlgorithm variants - #260
Merged
Merged
Conversation
…gorithm variants Cms* -> CountMinSketch*, Kll/Hll/Kmv -> KLL/HLL/KMV (incl. Hydra and HLLHip/KLLDynamic), Elastic/Coco -> ElasticSketch/CocoSketch, MicroCm -> MicroCountMinSketch, CmsHll -> CountMinSketchHLL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Review on #254 asked for full names and upper-case acronyms in the
SketchAlgorithmvariants, for exampleCountMinSketchinstead ofCmsandHydraKLLinstead ofHydraKll. #254 merged before those comments were addressed.What
This PR renames the
SketchAlgorithmvariants. Only the variants change: the rows, the statistic names and the sketch struct names stay as they are.Cms,CmsWithHeap,CmsWithSpaceSaving,CmsFoldCountMinSketch,CountMinSketchWithHeap,CountMinSketchWithSpaceSaving,CountMinSketchFoldHydraCmsHydraCountMinSketchKll,KllDynamic,HydraKllKLL,KLLDynamic,HydraKLLHll,HllHip,HydraHllHLL,HLLHip,HydraHLLKmvKMVElastic,CocoElasticSketch,CocoSketchCmsHll,MicroCm(experimental)CountMinSketchHLL,MicroCountMinSketchHow
The renames apply to the enum,
ALL,capability()andtests/capability.rs. The CHANGELOG entry for the unreleased table now states the naming rule.Before
SketchAlgorithm::Cms,SketchAlgorithm::HydraKll; serde writes"Cms".After
SketchAlgorithm::CountMinSketch,SketchAlgorithm::HydraKLL; serde writes"CountMinSketch". The ASAPPlanner adopts the new names in the same change that pins this commit.Verification
cargo test --test capability --all-features: 3 passed.cargo test --lib capability: passed.cargo clippy --all-targets --all-features -- -D warnings: clean.cargo fmt --check: clean.🤖 Generated with Claude Code