Repository navigation
Add saturation study: error vs N, N_saturation and Pareto value data #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
67686d9
Add Pareto distribution to datagen and --dataset pareto
zzylol a12801d
Add saturation study script
zzylol c72e9d4
Widen the saturation band by seed standard error
zzylol a18ab4b
Document the saturation study and add its plotting scripts
zzylol 4b6e19c
Allow --dataset pareto --dtype i64 (floored draws)
zzylol 61ff74e
Saturation study: config grid, exact-baseline crossover, phase split
zzylol 29aace0
Saturation study: --resume and --cost-rows
zzylol 51cb65a
Saturation plots: draw one config per sketch from grid output
zzylol 36b10a5
Saturation study: config-grid and 1e9 results
zzylol 3253393
Saturation study: recommend a sketch config per query from worst-case…
zzylol 5109343
Add saturation study figures with reading guides
zzylol 3b4236e
Saturation study: grid cost results and a per-query crossover N*
zzylol c0780ad
Add the grid crossover and recommendation tables
zzylol 05115ed
Document the saturation study's conclusions and the math behind them
zzylol 2c9a83e
Update merge conclusions with the full top-k and KLL grids
zzylol 19c8419
Key saved cost records and keep out-of-grid curves on resume
milindsrivastava1997 19fd917
Cancel queued accuracy runs when one fails
milindsrivastava1997 e4fa66c
Match cardinality as a number in point_key
milindsrivastava1997 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Pareto arm never runs. The cardinality lookup just before the
match(column.cardinality.or_else(|| column.distribution.domain()...)?) returnsNonefor Pareto, so the function exits first:domain()isNonefor Pareto,--dataset paretosetscardinality: None, andColumnSpecvalidation rejects any cardinality on an unbounded distribution. As a result, every Pareto record (including the KLL/DDSketch cost runs) is exported with noerp_shape, and nothing warns about it. Fix: give unbounded families a path that doesn't need a cardinality, or remove this arm.