Skip to content

fix(metadata): allow setting zero royalty address when royalty basis points is zero #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yappermoar-boop wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(metadata): allow setting zero royalty address when royalty basis points is zero #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ERC721ContractMetadata.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,8 @@ contract ERC721ContractMetadata is
// Ensure the sender is only the owner or contract itself.
_onlyOwnerOrSelf();

// Revert if the new royalty address is the zero address.
if (newInfo.royaltyAddress == address(0)) {
// Revert if the new royalty address is the zero address and basis points is non-zero.
if (newInfo.royaltyAddress == address(0) && newInfo.royaltyBps != 0) {
revert RoyaltyAddressCannotBeZeroAddress();
}

Expand Down