Skip to content

feat(llm): Extend effort parameter in TextLLMParams to include 'max' option - #1103

Merged
AkhileshNegi merged 3 commits into
mainfrom
chore/max-literal-llm-config
Aug 3, 2026
Merged

feat(llm): Extend effort parameter in TextLLMParams to include 'max' option#1103
AkhileshNegi merged 3 commits into
mainfrom
chore/max-literal-llm-config

Conversation

@vprashrex

@vprashrex vprashrex commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Issue

Closes #1102

Summary

  • Before: Existing configuration for LLMs was limited.
  • Now: Configurations are more flexible and support literal parameters.
  • Required updates to the configuration structure.
  • Adjusted validation to handle new parameter types.

Checklist

Before submitting a pull request, please ensure that you mark these task.

  • Ran fastapi run --reload app/main.py or docker compose up in the repository root and test.
  • If you've fixed a bug or added code that is tested and has test cases.

Notes

Please add here if any other information is required for the reviewer.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

Reasoning Effort Support

Layer / File(s) Summary
Expand effort validation
backend/app/models/llm/request.py
TextLLMParams.effort now permits the "max" reasoning-effort value.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: akhileshnegi, prajna1999

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR adds the "max" validation value but does not seed the required GPT-5.6 model configurations, modalities, completion type, or pricing data from issue #1102. Add model_config seed rows for Sol, Terra, and Luna with all required provider, effort, pricing, modality, and completion type fields.
✅ Passed checks (4 passed)
Check name Status Explanation
Out of Scope Changes check ✅ Passed The only change supports a requirement in issue #1102 and is not out of scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the addition of the "max" option to TextLLMParams.effort.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/max-literal-llm-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot changed the title Chore/max-literal-llm-config chore(llm): Improve configuration flexibility Aug 3, 2026
@vprashrex vprashrex changed the title chore(llm): Improve configuration flexibility feat(llm): Extend effort parameter in TextLLMParams to include 'max' option Aug 3, 2026
@vprashrex
vprashrex requested a review from AkhileshNegi August 3, 2026 09:48
@vprashrex vprashrex self-assigned this Aug 3, 2026
@vprashrex vprashrex added enhancement New feature or request ready-for-review ready-for-merge and removed enhancement New feature or request labels Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

OpenAPI changes   ⚪ No API surface changes

Note

This PR does not modify the API contract.

main24578fac · generated by oasdiff

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
backend/app/models/llm/request.py (1)

45-47: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add a regression test for "max".

The supplied mapper test covers reasoning, not effort. Add a test that constructs TextLLMParams(effort="max") and verifies that serialization preserves the value.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@backend/app/models/llm/request.py` around lines 45 - 47, Add a regression
test for the TextLLMParams mapper that constructs TextLLMParams with
effort="max" and asserts serialized output retains the "max" value; keep the
existing reasoning coverage unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@backend/app/models/llm/request.py`:
- Around line 45-47: Add a regression test for the TextLLMParams mapper that
constructs TextLLMParams with effort="max" and asserts serialized output retains
the "max" value; keep the existing reasoning coverage unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f40fd36f-ff61-47d2-9707-2e8e653f39dc

📥 Commits

Reviewing files that changed from the base of the PR and between 6e05a28 and 3427c82.

📒 Files selected for processing (1)
  • backend/app/models/llm/request.py

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@AkhileshNegi
AkhileshNegi merged commit cfd1788 into main Aug 3, 2026
@AkhileshNegi
AkhileshNegi deleted the chore/max-literal-llm-config branch August 3, 2026 13:04
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 1.4.0-main.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model Config: Add GPT-5.6 support

2 participants