feat(llm): Extend effort parameter in TextLLMParams to include 'max' option - #1103
Conversation
📝 WalkthroughWalkthroughChangesReasoning Effort Support
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
OpenAPI changes ⚪ No API surface changesNote This PR does not modify the API contract.
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
backend/app/models/llm/request.py (1)
45-47: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd a regression test for
"max".The supplied mapper test covers
reasoning, noteffort. Add a test that constructsTextLLMParams(effort="max")and verifies that serialization preserves the value.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@backend/app/models/llm/request.py` around lines 45 - 47, Add a regression test for the TextLLMParams mapper that constructs TextLLMParams with effort="max" and asserts serialized output retains the "max" value; keep the existing reasoning coverage unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@backend/app/models/llm/request.py`:
- Around line 45-47: Add a regression test for the TextLLMParams mapper that
constructs TextLLMParams with effort="max" and asserts serialized output retains
the "max" value; keep the existing reasoning coverage unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: f40fd36f-ff61-47d2-9707-2e8e653f39dc
📒 Files selected for processing (1)
backend/app/models/llm/request.py
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
🎉 This PR is included in version 1.4.0-main.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Issue
Closes #1102
Summary
Checklist
Before submitting a pull request, please ensure that you mark these task.
fastapi run --reload app/main.pyordocker compose upin the repository root and test.Notes
Please add here if any other information is required for the reviewer.