Split-TU: extract EnsureDeferredSiblingAndInlineNewProducers (#36387) - #37000
Merged
PurHur merged 1 commit intoSep 6, 2026
Merged
Conversation
Move ensureDeferredSiblingInlineCallArgProducersCompiled + multi-arg inline New_ match (~660 lines) out of SiblingInlineFuncCallProducers so gen-0 split-TU can hollow a smaller Concern TU. Ratchet Compiler hub budget 1082→1085 and spine 8323→8324. Mirrors php-src Zend/zend_execute.c ZEND_SEND_* adjacent call-arg wiring — move-only (Part of #36224 slice 2). Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-36387-ensure-deferred-sibling-inline-new
branch
from
September 6, 2026 10:52
e0a44a3 to
9076ab4
Compare
PurHur
deleted the
agent/issue-36387-ensure-deferred-sibling-inline-new
branch
September 6, 2026 10:52
This was referenced Sep 6, 2026
PurHur
added a commit
that referenced
this pull request
Sep 6, 2026
* Split-TU: extract HoistedMultiArgSiblingFuncCallChain (#36387) Move hoisted multi-arg sibling FuncCall chain helpers (~1006 lines) out of SiblingInlineFuncCallProducers so gen-0 split-TU can hollow a smaller Concern TU. Leaves SiblingInlineFuncCallProducers as a thin hub; New_/deferred already lives in EnsureDeferredSiblingAndInlineNewProducers (#37000). Ratchet Compiler hub budget 1088→1091 and spine 8325→8326. Mirrors php-src Zend/zend_execute.c ZEND_SEND_* adjacent call-arg wiring — move-only. Co-authored-by: Cursor <cursoragent@cursor.com> * Split-TU: sync spine 8327 footnotes after rebase onto #37002 Ratchet inventory/status footnotes and BundleTest to 8327/8327 after rebasing HoistedMultiArgSiblingFuncCallChain onto tip (post #37000/#37002). Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnsureDeferredSiblingAndInlineNewProducers(~660 lines) out ofSiblingInlineFuncCallProducers—ensureDeferredSiblingInlineCallArgProducersCompiled, multi-arg inlineNew_match, andcfgCallOpIndex(Part of Performance: compile-time targets and gate — hello-world ≤ 3 s warm, MiniWebApp ≤ 10 s, 400 statements per function in < 5 s, one-file edit rebuild < 25 % of full, spine gen-0 < 30 min with split-TU (script/bench-gate.php --compile, bin/compile.php, lib/Compiler.php) (re-#36224 slice 2, re-#36199) #36387 / Compiler:Compiler::compileis super-quadratic (~n^2.65) in statements per block — 200 call statements take 412 s;compileCallArgSendsruns 13 backward-scan matchers per call (lib/Compiler.php:49687) #36224 slice 2).require_once+ sidecar stamp SHA-1; Compiler hub budget 1085→1088; spine 8324→8325.Zend/zend_execute.cZEND_SEND_*adjacent call-arg wiring — no behavior change (opcode-corpus-md5identical).Closes nothing (Part of #36387).
Test plan
php script/check-size-budgets.php→ OKphp script/check-selfhost-spine-count-sync.php→ OK (8325/8325)php script/opcode-corpus-md5.php --check→ OK (aggregate unchanged)./script/phpunit.sh --filter BootstrapSelfhostBundleTest→ OK (4 tests)./script/aot-smoke.sh→ 9/9 (pre-rebase tip; move-only)make north-star5-verify-fast→ OK (spine 8325/8325)Made with Cursor