Split-TU: extract ArrayPadUnpackExtractAndDateSunCallArgSends (#36387) - #37052
Merged
PurHur merged 1 commit intoSep 6, 2026
Merged
Conversation
Move remaining array_pad / unpack / extract / date_sun_* inline ARG_SEND compilers (~670 lines) out of CompileInlineSpecializedCallArgSends so gen-0 split-TU can hollow that Concern TU (empty hub; complements #37043 ExplodeIterator extract). Hub wire + spine require + sidecar stamp; ratchet Compiler hub budget 1136→1139 and spine 8341→8342. Move-only — mirrors php-src Zend/zend_compile.c and ext/standard array/date call-arg send wiring. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
deleted the
agent/issue-36387-array-pad-unpack-date-sun-callarg
branch
September 6, 2026 19:17
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
array_pad/ unpack / extract /date_sun_*inline ARG_SEND compilers (compileArrayPadInlineHaystackCallArgSends→compileDateSunFuncInlineCallArgSends, ~670 lines) fromCompileInlineSpecializedCallArgSendsintoArrayPadUnpackExtractAndDateSunCallArgSends, leaving an empty hub trait (complements Split-TU: extract ExplodeIteratorChunkWalkAndTrailingComparatorCallArgSends (#36387) #37043 ExplodeIterator extract) so gen-0 split-TU can hollow that Concern TU (Part of Performance: compile-time targets and gate — hello-world ≤ 3 s warm, MiniWebApp ≤ 10 s, 400 statements per function in < 5 s, one-file edit rebuild < 25 % of full, spine gen-0 < 30 min with split-TU (script/bench-gate.php --compile, bin/compile.php, lib/Compiler.php) (re-#36224 slice 2, re-#36199) #36387 / prior Build: spine split-TU — per-module LLVM objects instead of 8053-file monolith (gen-0 rebuild) #36147).require_once+ sidecar stamp; ratchet Compiler hub budget 1142→1145 and spine 8343→8344.Zend/zend_compile.c/ext/standardarray and date call-arg send wiring — no behavior change intended.Part of #36387
Test plan
./script/phpunit.sh --filter 'BootstrapSelfhostBundleTest|SizeBudget'→ OK (4 tests, 537 assertions)./script/aot-smoke.sh→ 9/9 + size gate OK (verified pre-final tip-ratchet rebase; move-only Concern extract)make north-star5-verify-fast→ OK (spine 8342/8342 on earlier tip; post-rebase inventory 8344/8344 via spine-sync)php script/check-selfhost-spine-sidecar-sync.php→ OK (via spine-sync)./script/check-size-budgets.sh→ OK (via SizeBudget filter)script/differential-sweep.sh --aot --repeat 3(move-only Concern extract)Made with Cursor