Trust: extract TryCatchFinallyAndUncaughtDispatch from VM.php (#36403) - #37057
Merged
Conversation
Move-only Concern split for try/catch/finally unwind and uncaught dispatch so VM.php can ratchet under the size-budget ceiling (17422 → 16545). Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-36403-try-catch-finally-concern
branch
from
September 6, 2026 19:41
6ddf0a9 to
9dc8f39
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TryCatchFinallyAndUncaughtDispatch(findCatchFrameForThrow→raiseUncaughtExceptionWithNext) fromlib/VM.phplib/VM.php17422 → 16545 (target 15k)Part of #36403
php-src:
Zend/zend_exceptions.c(zend_throw_exception_internal/ catch matching),Zend/zend_vm_def.hZEND_CATCH/ZEND_FAST_CALLfinally, return-through-finally unwind. No new C ABI; no opcode/IR shape change.Test plan
php script/check-size-budgets.php→ OK (lib/VM.php16545/16545)php script/bootstrap-inventory.php --check→ OK (8345/8345)php script/check-selfhost-spine-coverage-sync.php→ OKphp script/check-selfhost-spine-sidecar-sync.php→ OK./script/aot-smoke.sh→ 9/9 + size gate OKmake north-star5-verify-fast→ OK (spine 8345/8345)fin1/catch:x/fin2/7)script/differential-sweep.sh --aot(move-only extract; no lowering change)Made with Cursor