Split-TU: extract InitArraySpreadArithmeticAndNestedInlineCallArgResolvers (#36387) - #37062
Closed
PurHur wants to merge 2 commits into
Closed
Split-TU: extract InitArraySpreadArithmeticAndNestedInlineCallArgResolvers (#36387)#37062PurHur wants to merge 2 commits into
PurHur wants to merge 2 commits into
Conversation
…lvers (#36387) Move INIT_ARRAY / array-spread / inline-arithmetic / nested-subject call-arg slot resolvers (~641 lines) out of SlotForCallArgResolvers so gen-0 split-TU can hollow a smaller Concern TU. Hub wire + spine require + sidecar stamp; ratchet Compiler hub budget. Leaves closure/FCC tail in place. Mirrors php-src Zend/zend_execute.c ZEND_SEND_* adjacent call-arg wiring — move-only. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
PurHur
deleted the
agent/issue-36387-init-array-spread-nested-callarg-resolvers
branch
September 6, 2026 20:22
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slotForRecentInitArrayCallArg→nestedInlineFuncCallProducerForCallArg(~641 lines) fromSlotForCallArgResolversintoInitArraySpreadArithmeticAndNestedInlineCallArgResolvers.SlotForInlineClosureAndFirstClassCallableCallArgResolvers). Hub wire + spine require + sidecar stamp; Compiler hub budget 1151→1154; spine 8347→8348.Zend/zend_execute.cZEND_SEND_*adjacent call-arg wiring — no new C ABI.Test plan
./script/aot-smoke.sh→ 9/9 + size gate OK (post-rebase)make north-star5-verify-fast→ OK (spine 8348/8348)php script/check-selfhost-spine-count-sync.php/ sidecar sync /check-size-budgets/check-generated-docs→ OKscript/differential-sweep.sh --aot --repeat 3(move-only; opcode corpus unchanged)Part of #36387.
Made with Cursor