Skip to content

Split-TU: extract CompileExprAndOpcodeTypes (#36387) - #37065

Merged
PurHur merged 2 commits into
masterfrom
agent/issue-36387-compile-expr-opcode-types
Sep 6, 2026
Merged

Split-TU: extract CompileExprAndOpcodeTypes (#36387)#37065
PurHur merged 2 commits into
masterfrom
agent/issue-36387-compile-expr-opcode-types

Conversation

@PurHur

@PurHur PurHur commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

Test plan

  • ./script/aot-smoke.sh9/9 + size gate OK
  • make north-star5-verify-fast → OK (spine 8350/8350)
  • php script/check-selfhost-spine-sidecar-sync.php / check-size-budgets → OK
  • Not run: script/differential-sweep.sh --aot --repeat 3 (move-only; opcode corpus unchanged)

Part of #36387.

Made with Cursor

PurHur and others added 2 commits September 6, 2026 20:38
Move getOpCodeTypeFromBinaryOp / Cast / Unary, compileIncDecExpr, and
compileExpr (~960 lines) out of ErrorSuppressAndPropertyFetch so gen-0
split-TU can hollow a smaller Concern TU. Hub wire + spine require +
sidecar stamp; ratchet Compiler hub budget and spine 8349→8350.
Move-only — mirrors php-src Zend/zend_compile.c expression compile.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant