Skip to content

internal: do not hardcode MSRV in README badge - #6378

Merged
bschoenmaeckers merged 3 commits into
PyO3:mainfrom
chirizxc:patch-2
Sep 16, 2026
Merged

bschoenmaeckers merged 3 commits into
PyO3:mainfrom
chirizxc:patch-2

Conversation

@chirizxc

@chirizxc chirizxc commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

btw, instead of hardcoding MSRV, we can get it from https://crates.io/api/v1/crates/pyo3 (versions[0].rust_version)

изображение изображение

@davidhewitt

Copy link
Copy Markdown
Member

The dynamic versioning is quite convenient. I don't quite understand the need to switch from shields.io, is there a particular motivation other than a design refresh? Can we do that with some theming on shields.io?

@chirizxc

chirizxc commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Can we do that with some theming on shields.io?

minimum rustc

[![minimum rustc](https://img.shields.io/badge/dynamic/json?url=https://crates.io/api/v1/crates/pyo3&query=$.versions[0].rust_version&label=rustc&suffix=%2B&color=blue&logo=rust)](https://rust-lang.github.io/rfcs/2495-min-rust-version.html)

@davidhewitt

Copy link
Copy Markdown
Member

👍 in which case I think:

  • let's stick to shields.io, I see no reason to move
  • the dynamic rust version looks handy given we often forget to update it and all the other badges are dynamic
  • I'm ok with new themes, if shields.io supports it and you want to propose some

@chirizxc

chirizxc commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

👍 in which case I think:

* let's stick to shields.io, I see no reason to move

* the dynamic rust version looks handy given we often forget to update it and all the other badges are dynamic

* I'm ok with new themes, if shields.io supports it and you want to propose some

done

@bschoenmaeckers bschoenmaeckers changed the title internal: new badges internal: do not hardcode MSRV in README badge Sep 16, 2026
@bschoenmaeckers
bschoenmaeckers added this pull request to the merge queue Sep 16, 2026
Merged via the queue into PyO3:main with commit 2ca6cb7 Sep 16, 2026
52 of 54 checks passed
davidhewitt pushed a commit that referenced this pull request Sep 17, 2026
* internal: new badges

* Update README.md

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants