fix FFI cases where PyPy replaced function with macro - #6422
Merged
Merged
Conversation
| pub fn PySet_CheckExact(op: *mut PyObject) -> c_int; | ||
|
|
||
| #[cfg(any(PyPy, RustPython))] | ||
| #[cfg(any(all(PyPy, not(Py_3_12)), RustPython))] |
Member
There was a problem hiding this comment.
Their goal is to be abi3 compatible right? Will this be compatible?
Member
Author
There was a problem hiding this comment.
I think so, yes, this is moving towards consistency with the CPython declaration on PyPy 3.12 (i.e. there is no such symbol, just a macro)
bschoenmaeckers
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes cases PyPy replaced functions with macros in its c-api; due to ordering of checks in
pyo3-ffi-checkwe weren't detecting them.Similar to #6421 I used local AI to diagnose and produce this patch under my review; it follows the existing mechanical patterns in the codebase.