feat: expose Q10 current cleaning room - #939
Open
hCoureau wants to merge 5 commits into
Open
Conversation
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Important
This is a stacked pull request. It depends on #938, #937, #936, and #933. The isolated change for review is commit
cd2621d. It will be rebased ontomainafter its predecessors merge, before merge.Design against the #933 review priorities
map.current_roomreturns the existing typedQ10RoomorNone; it does not add a second room model or expose inference details to callers.Noneon room ambiguity or unusable calibration.Validation
1051 passed, including92snapshot testsThe behavior was also exercised against a physical Roborock Q10 S5. No private map captures, room labels, or account data are included.
Related work
AI assistance disclosure
This contribution was prepared with OpenAI Codex assistance. I reviewed the submitted changes and test results and take responsibility for the contribution.