fix: CompatHelper PRs made with BOT_PAT were never recognised as bot PRs - #30
Merged
Merged
Conversation
With BOT_PAT a CompatHelper PR is authored by the PAT's owner, a User. Three checks assumed otherwise: - CompatHelper's duplicate check counts only PRs by github-actions[bot], so every scheduled run reopened the same PR (15 copies on DataVault.jl). Pass the token's own login as `username`. - automerge and version-check keyed on user.type == 'Bot', so these PRs were never auto-merged and always failed check-version. Recognise them by a compathelper/ or dependabot/ branch in the same repository too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
BOT_PAT, a CompatHelper PR is authored by the PAT's owner (aUser). Three reusable workflows assumed a bot author:compathelper.ymlgithub-actions[bot]as duplicatesautomerge.ymluser.type == 'Bot'version-check.ymluser.type == 'Bot'exempts from the version bumpcheck-versionFix
compathelper.yml: pass the token's own login (gh api user) asCompatHelper.GitHubActions(; username). UnderGITHUB_TOKEN,/userfails and the default is kept.automerge.yml/version-check.yml: also treat a PR from acompathelper/ordependabot/branch in the same repository as a dependency PR. Thehead.repocheck keeps forks out. Theuser.type == 'Bot'path is unchanged.Checked locally
my_prson a PR bysotashimozono:falsewith the default username,truewith the passed login.Takes effect on the next scheduled CompatHelper run (every 4h). DataVault.jl's Artifacts false positive is fixed separately in QAtlasHub/DataVault.jl#74, which should merge first: once this lands, that proposal would otherwise auto-merge.
🤖 Generated with Claude Code