Refactor Manager class and update method organization - #23
Draft
Quantumyilmaz wants to merge 4 commits into
Draft
Conversation
Reorganized and grouped methods in Manager.h for clarity, moving serialization, Papyrus, hooks, and event methods into logical sections. Updated method signatures and moved some method implementations in Manager.cpp for better structure. Replaced OnLongPressEquip with OnOpen in Hooks.cpp and Manager.cpp. No functional logic was changed, but code readability and maintainability are improved.
Introduced GetRename() helper to centralize and simplify rename lookups for fake IDs. Updated usages in Manager.cpp and Manager.h to use the new method, improving code clarity and reducing duplication.
Eliminated redundant logger::trace statements to reduce log verbosity and improve performance. Also added ChestManager::Reset() to LoadCallback for proper state reset during data loading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganized and grouped methods in Manager.h for clarity, moving serialization, Papyrus, hooks, and event methods into logical sections. Updated method signatures and moved some method implementations in Manager.cpp for better structure. Replaced OnLongPressEquip with OnOpen in Hooks.cpp and Manager.cpp. No functional logic was changed, but code readability and maintainability are improved.