Repository navigation
ppvm-phased-pauli-word-2 Crate Refactor - #279
Merged
Merged
Conversation
…rd-2 own it instead
…Implemented clifford traits for it
Contributor
|
david-pl
requested changes
Nov 5, 2026
david-pl
left a comment
david-pl
left a comment
Collaborator
There was a problem hiding this comment.
Good PR, just needs some small changes.
…ose trait implementations across ppvm-traits-2, ppvm-lossy-pauli-word-2, and the new phase one
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
david-pl
approved these changes
Nov 6, 2026
| } | ||
|
|
||
| /// Loss state associated with word sites. | ||
| pub trait LossState { |
Collaborator
There was a problem hiding this comment.
Should we make this LossState: LossInfo?
Contributor
Author
There was a problem hiding this comment.
that's a good idea, yeah, I'll include that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces refactoring the ppvm-phased-pauli-word-2 crate from #204 . On top of that PR, this resulted in the following changes:
ppvm-*-2#204 without any changes